refactor: fix event names used to track notifications#25521
Merged
Prithpal-Sooriya merged 12 commits intodevelopfrom Jul 26, 2024
Merged
refactor: fix event names used to track notifications#25521Prithpal-Sooriya merged 12 commits intodevelopfrom
Prithpal-Sooriya merged 12 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
PR Summary
This PR updates event names and properties for tracking notifications to ensure consistency and adherence to conventions.
app/scripts/metamask-controller.js: RenamedPushNotificationClickedtoNotificationClickedand added properties likenotification_id,notification_is_read, andclick_type.shared/constants/metametrics.ts: Standardized MetaMetrics event names for better consistency.ui/components/app/modals/turn-on-metamask-notifications/turn-on-metamask-notifications.tsx: Updated event names and added propertiesis_notifications_enabledandaction_type.ui/components/multichain/global-menu/global-menu.js: Renamed event names and properties for notification tracking.ui/pages/notifications-settings/notifications-settings-allow-notifications.tsx: Replaced specific event names withNotificationsSettingsUpdatedand added propertiessetting_type,old_value, andnew_value.
12 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings
Prithpal-Sooriya
previously approved these changes
Jul 26, 2024
mathieuartu
previously approved these changes
Jul 26, 2024
d7c77cd
add the missing segment events for onboarding snapshots
Collaborator
Builds ready [d7c77cd]
Page Load Metrics (227 ± 226 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25521 +/- ##
===========================================
+ Coverage 69.94% 69.95% +0.01%
===========================================
Files 1409 1409
Lines 49794 49779 -15
Branches 13773 13767 -6
===========================================
- Hits 34826 34818 -8
+ Misses 14968 14961 -7 ☔ View full report in Codecov by Sentry. |
Prithpal-Sooriya
approved these changes
Jul 26, 2024
mathieuartu
approved these changes
Jul 26, 2024
|
Collaborator
Builds ready [5a7ea8e]
Page Load Metrics (60 ± 7 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies the names of some tracked events to monitor the use of notifications, ensuring they adhere to the conventions used.
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist