fix: account missing in connection page by montelaidev · Pull Request #25500 · MetaMask/metamask-extension

montelaidev · 2024-06-25T07:31:34Z

Description

This PR fixes a regression where the connected account is not showing up on the page.

Related issues

Fixes #25844

Manual testing steps

Go to a test dapp
Connect the account
Open the popup
Click on the connection icon and see the connected account.

Screenshots/Recordings

Before

After

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-06-25T07:31:50Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-06-25T16:17:56Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (198bedd) to head (7c41c46).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #25500   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1364     1364           
  Lines        48172    48173    +1     
  Branches     13291    13291           
========================================
+ Hits         33526    33527    +1     
  Misses       14646    14646

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-06-25T16:29:08Z

Builds ready [95c4eb2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (49 ± 3 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	67	107	82	9	4
		domContentLoaded	9	21	12	3	2
		load	41	65	49	7	3
		domInteractive	9	21	12	3	2

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 67 Bytes (0.00%)
common: 0 Bytes (0.00%)

sonarqubecloud · 2024-07-02T08:31:54Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

metamaskbot · 2024-07-02T09:00:12Z

Builds ready [7c41c46]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (68 ± 17 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	291	101	47	23
		domContentLoaded	9	89	25	18	9
		load	41	201	68	36	17
		domInteractive	9	89	25	18	9

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 64 Bytes (0.00%)
common: 0 Bytes (0.00%)

fix: connection

a318881

montelaidev added the team-accounts-framework Accounts team label Jun 25, 2024

montelaidev self-assigned this Jun 25, 2024

montelaidev added 4 commits June 25, 2024 20:37

fix: update snapshot

f53298b

fix: snapshot

59f0329

Merge branch 'develop' into fix/connected-sites

22bb088

fix: snapshots

95c4eb2

montelaidev marked this pull request as ready for review June 25, 2024 17:13

montelaidev requested review from a team as code owners June 25, 2024 17:13

matthewwalsh0 previously approved these changes Jun 26, 2024

View reviewed changes

Merge branch 'develop' into fix/connected-sites

295c227

NidhiKJha previously approved these changes Jun 27, 2024

View reviewed changes

montelaidev added 2 commits June 27, 2024 18:30

Merge branch 'develop' into fix/connected-sites

7d4c8fe

fix: update snapshot

1afa399

montelaidev dismissed stale reviews from NidhiKJha and matthewwalsh0 via 1afa399 June 27, 2024 13:45

montelaidev requested review from NidhiKJha and matthewwalsh0 June 27, 2024 14:53

ccharly previously approved these changes Jun 27, 2024

View reviewed changes

digiwand previously approved these changes Jun 27, 2024

View reviewed changes

Merge branch 'develop' into fix/connected-sites

c61c06f

NidhiKJha mentioned this pull request Jul 1, 2024

fix: updated switch to this account condition #25609

Merged

7 tasks

montelaidev and others added 3 commits July 2, 2024 07:40

Merge branch 'develop' into fix/connected-sites

da9ac80

fix(multichain): fix prop type in ConnectedSiteMenu

0f1bf59

fix: skip test until firefox issue is resolved

9989627

montelaidev dismissed digiwand’s stale review via 9989627 July 2, 2024 08:09

montelaidev dismissed ccharly’s stale review via 9989627 July 2, 2024 08:09

montelaidev requested a review from ccharly July 2, 2024 08:14

fix: comment out skipped test

7c41c46

ccharly approved these changes Jul 2, 2024

View reviewed changes

matthewwalsh0 approved these changes Jul 2, 2024

View reviewed changes

montelaidev merged commit d721e7f into develop Jul 2, 2024

montelaidev deleted the fix/connected-sites branch July 2, 2024 12:17

github-actions bot locked and limited conversation to collaborators Jul 2, 2024

metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: account missing in connection page#25500

fix: account missing in connection page#25500
montelaidev merged 13 commits intodevelopfrom
fix/connected-sites

montelaidev commented Jun 25, 2024 •

edited by gantunesr

Loading

Uh oh!

github-actions bot commented Jun 25, 2024

Uh oh!

codecov bot commented Jun 25, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Jun 25, 2024

Uh oh!

sonarqubecloud bot commented Jul 2, 2024

Uh oh!

metamaskbot commented Jul 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Conversation

montelaidev commented Jun 25, 2024 • edited by gantunesr Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented Jun 25, 2024

Uh oh!

codecov bot commented Jun 25, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented Jun 25, 2024

Uh oh!

sonarqubecloud bot commented Jul 2, 2024

Quality Gate passed

Uh oh!

metamaskbot commented Jul 2, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

montelaidev commented Jun 25, 2024 •

edited by gantunesr

Loading

codecov bot commented Jun 25, 2024 •

edited

Loading