Skip to content

fix: Fix issue 22837 about unknown error during ledger pair#25462

Merged
dawnseeker8 merged 10 commits intodevelopfrom
fix/22837-unknown-error-during-ledger-pair
Jul 2, 2024
Merged

fix: Fix issue 22837 about unknown error during ledger pair#25462
dawnseeker8 merged 10 commits intodevelopfrom
fix/22837-unknown-error-during-ledger-pair

Conversation

@dawnseeker8
Copy link
Copy Markdown
Contributor

@dawnseeker8 dawnseeker8 commented Jun 21, 2024 •
edited
Loading

Description

Issue #22837 descrip that ledger sometimes will display Unknown Error during pairing. we have tried to replicate the issue and discover that it happen during ledger is lock and not open Eth app. this PR will replace the Unknown Error with more meaningful error message to guide user solve the issue.

Open in GitHub Codespaces

Related issues

Fixes: #22837

Manual testing steps

  1. Setup wallet
  2. Connect, unlock and open the Ethereum app on Ledger
  3. Use the add hardware flow to add some Ledger accounts
  4. Remove the Ledger accounts from full screen mode
  5. Use add hardware flow to try and add any Ledger accounts
  6. Select the paired with that ledger when it is available
  7. ledger should be locked status or unlock ledger but not opening eth app.
  8. you will see new error message Unlock your Ledger device and open the ETH app
  9. After you unlock your ledger and open ETH app. and click paired again
  10. you should be able to select accounts from next screen and import those accounts from ledger.

Screenshots/Recordings

Before

https://recordit.co/kdCDL4laWo

After

Screen.Recording.2024-06-21.at.12.14.58.mov

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dawnseeker8 dawnseeker8 requested a review from a team as a code owner June 21, 2024 10:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 21, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dawnseeker8 dawnseeker8 added team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jun 21, 2024
@dawnseeker8 dawnseeker8 changed the title Fix/22837 unknown error during ledger pair fix: Fix issue 22837 about unknown error during ledger pair Jun 21, 2024
@metamaskbot metamaskbot added the team-accounts-framework Accounts team label Jun 21, 2024
@dawnseeker8 dawnseeker8 mentioned this pull request Jun 21, 2024
Closed
@dawnseeker8 dawnseeker8 added the e2e-test End to end test for the MetaMask extension label Jun 21, 2024
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (03fc8a9) to head (1c1e362).
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25462   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1364     1364           
  Lines        48172    48172           
  Branches     13291    13291           
========================================
  Hits         33526    33526           
  Misses       14646    14646

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 21, 2024

Builds ready [c8db753]
Page Load Metrics (129 ± 145 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint65266934120
domContentLoaded98316168
load421436129302145
domInteractive98316168
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 29 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@angelcheung22 angelcheung22 removed the team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead label Jun 28, 2024
@vivek-consensys
Copy link
Copy Markdown
Contributor

vivek-consensys commented Jul 2, 2024

Built locally and tested, working as expected.

chloeYue
chloeYue approved these changes Jul 2, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@chloeYue chloeYue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jul 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jul 2, 2024

Builds ready [1c1e362]
Page Load Metrics (261 ± 256 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint634631248239
domContentLoaded9165343316
load411911261534256
domInteractive9165343316
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 33 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@dawnseeker8 dawnseeker8 merged commit 7d94797 into develop Jul 2, 2024
@dawnseeker8 dawnseeker8 deleted the fix/22837-unknown-error-during-ledger-pair branch July 2, 2024 12:59
@github-actions github-actions bot locked and limited conversation to collaborators Jul 2, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jul 2, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jul 2, 2024
@gantunesr gantunesr added team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead and removed team-accounts-framework Accounts team labels Jul 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@chloeYue chloeYue chloeYue approved these changes

@vivek-consensys vivek-consensys vivek-consensys approved these changes

Assignees

No one assigned

Labels

e2e-test End to end test for the MetaMask extension QA Passed release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-hardware-wallets-deprecated DEPRECATED: please use "team-accounts-framework" instead

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: Unable to pair to Ledger a second time after removing accounts

6 participants

@dawnseeker8 @metamaskbot @vivek-consensys @chloeYue @gantunesr @angelcheung22