Fix lint errors on commit 5892d7cdc#25367
Merged
danjm merged 2 commits intoVersion-v11.16.12from Jun 17, 2024
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## Version-v11.16.12 #25367 +/- ##
====================================================
Coverage ? 67.30%
====================================================
Files ? 1266
Lines ? 49744
Branches ? 12924
====================================================
Hits ? 33477
Misses ? 16267
Partials ? 0 ☔ View full report in Codecov by Sentry. |
darkwing
approved these changes
Jun 17, 2024
Collaborator
Builds ready [c9a7892]
Page Load Metrics (322 ± 295 ms)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes lint errors and e2e failures on v11.16.12, which would have been introduced during conflict resolution when cherry-picking #24605
Specifically:
test/e2e/default-fixture.jsis deleted as that file does not exist on master yet and is not used. However, importantly, the change made intest/e2e/default-fixture.jsin feat: adds "data collection for marketing" toggles #24605 is now applied totest/e2e/fixture-builder.js(this was needed for e2e tests to pass)ui/pages/settings/security-tab/metametrics-toggle/metametrics-toggle.tsxand the associated test file, as these seem to be unusedui/pages/settings/security-tab/security-tab.component.js