Skip to content

chore: Create a story for RestoreVaultPage component#25284

Merged
garrettbear merged 1 commit intoMetaMask:developfrom
Devin-Applications:devin/story-xh5
Jul 1, 2024
Merged

chore: Create a story for RestoreVaultPage component#25284
garrettbear merged 1 commit intoMetaMask:developfrom
Devin-Applications:devin/story-xh5

Conversation

@Devin-Apps
Copy link
Copy Markdown
Contributor

@Devin-Apps Devin-Apps commented Jun 13, 2024

Description

This PR adds a Storybook story for the RestoreVaultPage component. The story allows for isolated testing and visualization of the RestoreVaultPage component within the Storybook UI.

Open in GitHub Codespaces

Related issues

Manual testing steps

  1. Go to the latest build of storybook in this PR
  2. Navigate to the RestoreVaultPage component in the Pages/Keychains folder.

Screenshots/Recordings

Screenshot 2024-06-13 at 7 34 21 AM Screenshot 2024-06-13 at 7 34 48 AM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Devin Run

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 13, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall requested a review from a team June 13, 2024 16:35
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 13, 2024
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just need to update snapshot

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's excellent that Devin has picked up the convention that the title should echo the folder path 💯

@georgewrmarshall georgewrmarshall marked this pull request as ready for review June 13, 2024 20:29
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner June 13, 2024 20:29
@georgewrmarshall georgewrmarshall marked this pull request as draft June 14, 2024 15:52
@georgewrmarshall
Copy link
Copy Markdown
Contributor

Needs rebase from develop

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (fe12ae4) to head (1911e9d).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop   #25284   +/-   ##
========================================
  Coverage    69.60%   69.60%           
========================================
  Files         1364     1364           
  Lines        48172    48172           
  Branches     13291    13291           
========================================
  Hits         33526    33526           
  Misses       14646    14646           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@garrettbear garrettbear marked this pull request as ready for review July 1, 2024 22:35
@garrettbear garrettbear merged commit 6aac159 into MetaMask:develop Jul 1, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jul 1, 2024
@metamaskbot metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Aug 19, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-12.2.0 on PR, as PR was added to branch 12.2.0 when release was cut.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

external-contributor release-12.2.0 Issue or pull request that will be included in release 12.2.0 team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants