refactor: Replace deprecated mixins with Text component in selected-account.component.js#25262
Merged
garrettbear merged 12 commits intoMetaMask:developfrom Jul 1, 2024
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Author
|
Tagging @georgewrmarshall for review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25262 +/- ##
========================================
Coverage 69.69% 69.69%
========================================
Files 1350 1350
Lines 47865 47865
Branches 13199 13199
========================================
Hits 33355 33355
Misses 14510 14510 ☔ View full report in Codecov by Sentry. |
ui/components/app/selected-account/selected-account.component.js
Outdated
Show resolved
Hide resolved
ui/components/app/selected-account/selected-account.component.js
Outdated
Show resolved
Hide resolved
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
Contributor
georgewrmarshall
left a comment
There was a problem hiding this comment.
Looking good! One suggestion
ui/components/app/selected-account/selected-account.component.js
Outdated
Show resolved
Hide resolved
Co-authored-by: George Marshall <georgewrmarshall@gmail.com>
garrettbear
approved these changes
Jul 1, 2024
Collaborator
|
No release label on PR. Adding release label release-12.2.0 on PR, as PR was added to branch 12.2.0 when release was cut. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaced deprecated mixins with Text component in
selected-account.component.js. The change aims to modernize the codebase by using the Text component from the design system, ensuring consistency and maintainability.Devin Run Link: https://preview.devin.ai/devin/6dcddd7b3ee2456ca004b34d033b0d82
Related issues
Partially Fixes: #20496
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist