Skip to content

chore: updating failing snapshot in develop#25261

Merged
georgewrmarshall merged 1 commit intodevelopfrom
fix/snapshot-security-tab
Jun 12, 2024
Merged

chore: updating failing snapshot in develop#25261
georgewrmarshall merged 1 commit intodevelopfrom
fix/snapshot-security-tab

Conversation

@georgewrmarshall
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall commented Jun 12, 2024 •
edited
Loading

Description

Fixes failing snapshot in develop most likely due to conflicts with #24605 and #24953

Slack thread

Open in GitHub Codespaces

Related issues

Fixes: N/A

Manual testing steps

  1. Pull this branch
  2. Run yarn jest
  3. See no failing snapshot tests

Screenshots/Recordings

N/A

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgewrmarshall georgewrmarshall self-assigned this Jun 12, 2024
@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label Jun 12, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 12, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall marked this pull request as ready for review June 12, 2024 16:08
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner June 12, 2024 16:08
Gudahtt
Gudahtt approved these changes Jun 12, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.55%. Comparing base (57b9c82) to head (123cea3).
Report is 8 commits behind head on develop.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop   #25261      +/-   ##
===========================================
- Coverage    65.65%   65.55%   -0.10%     
===========================================
  Files         1368     1372       +4     
  Lines        54269    54477     +208     
  Branches     14192    14266      +74     
===========================================
+ Hits         35627    35709      +82     
- Misses       18642    18768     +126

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgewrmarshall georgewrmarshall merged commit e0d6c42 into develop Jun 12, 2024
@georgewrmarshall georgewrmarshall deleted the fix/snapshot-security-tab branch June 12, 2024 16:54
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@davidmurdoch davidmurdoch davidmurdoch approved these changes

@Gudahtt Gudahtt Gudahtt approved these changes

+1 more reviewer

@bergeron bergeron bergeron approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@georgewrmarshall georgewrmarshall

Labels

release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-design-system All issues relating to design system in Extension

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@georgewrmarshall @davidmurdoch @Gudahtt @bergeron @metamaskbot