fix: fix typo in pre-build-mv2 and changed value of ENABLE_CONFIRMATION_REDESIGN#25258
Merged
DDDDDanica merged 1 commit intodevelopfrom Jun 13, 2024
Merged
fix: fix typo in pre-build-mv2 and changed value of ENABLE_CONFIRMATION_REDESIGN#25258DDDDDanica merged 1 commit intodevelopfrom
DDDDDanica merged 1 commit intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
vthomas13
approved these changes
Jun 12, 2024
chloeYue
approved these changes
Jun 12, 2024
danjm
approved these changes
Jun 12, 2024
danjm
reviewed
Jun 12, 2024
| - run: | ||
| name: Build extension for testing | ||
| command: ENABLE_CONFIRMATION_REDESIGN=1 yarn build:test | ||
| command: ENABLE_CONFIRMATION_REDESIGN=true yarn build:test |
Contributor
There was a problem hiding this comment.
Just a note that this change won't make a difference functionally
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25258 +/- ##
========================================
Coverage 65.64% 65.64%
========================================
Files 1367 1367
Lines 54257 54257
Branches 14189 14189
========================================
Hits 35616 35616
Misses 18641 18641 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [09b93dc]
Page Load Metrics (147 ± 195 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small fix for
pre-build-mv2description andENABLE_CONFIRMATION_REDESIGNvalue in circle ciRelated issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist