fix: Capture Segment errors during initialization#25253
Merged
Conversation
We were submitting Segment events in the MetaMetrics constructor without cathing errors. This was the sole place where we failed to catch errors resulting from Segment calls. Fixes #25244
FrederikBolding
previously approved these changes
Jun 12, 2024
FrederikBolding
approved these changes
Jun 12, 2024
legobeat
approved these changes
Jun 12, 2024
danjm
approved these changes
Jun 12, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25253 +/- ##
===========================================
- Coverage 65.64% 65.64% -0.00%
===========================================
Files 1367 1367
Lines 54257 54259 +2
Branches 14189 14189
===========================================
Hits 35616 35616
- Misses 18641 18643 +2 ☔ View full report in Codecov by Sentry. |
Member
Author
|
We will continue to investigate the linked bug and attempt reproducing it and addressing the root problem, but I will merge this PR first in the meantime to mitigate the issue. |
Collaborator
Builds ready [ac46850]
Page Load Metrics (49 ± 5 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Member
Author
|
See this comment for more details on manual testing: #25254 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We were submitting Segment events in the MetaMetrics constructor without catching errors. This was the sole place where we failed to catch errors resulting from Segment calls.
Related issues
Mitigates #25244
Manual testing steps
See this comment for details: #25254 (comment)
Screenshots/Recordings
N./A
Pre-merge author checklist
Pre-merge reviewer checklist