Description

This PR fixes the flaky test ENS domain resolves to a correct address

The error is:

[driver] Called 'clickElement' with arguments [".address-list-item"]
[driver] Called 'findElement' with arguments [{"css":".ens-input__selected-input__title","text":"test.eth"}]
Failure on testcase: 'ENS domain resolves to a correct address', for more information see the artifacts tab in CI

TimeoutError: Waiting for element to be located By(xpath, .//*[contains(concat(' ', normalize-space(./@class), ' '), ' ens-input__selected-input__title ')][(contains(string(.), 'test.eth') or contains(string(.), 'test.eth'))])`

The problem is that we are clicking the address-list-item button, and nothing happens afterwards. Then we try to find the next element but is not there.
If we look into the address-list-item button element we can see how it has nested elements inside, which will render the address and the ENS domain.
Clicking on a "container" element with other elements inside might not work as we expect, since the inside elements might not be fully updated before clicking with unknown effects (in this case, the ENS and address resolution) .

To fix this, we are doing 2 things:

• waiting for both the ENS and the address to be fully rendered (before we were just waiting for the ENS domain to be loaded)
• clicking on a more specific element inside the container -> we now click into the inner element for the domain ENS

See Box as the container button, and nested elements with address and ENS domain.

• ci failure example: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/86997/workflows/200911a8-50a6-42f2-b56a-b6f7afc8fc1e/jobs/3178850/artifacts

Related issues

Fixes: #24652

Manual testing steps

1. Check ci
2. Run test multiple times locally with different builds yarn test:e2e:single test/e2e/tests/transaction/ens.spec.js --browser=chrome --leave-running --retryUntilFailure --retries=10

Screenshots/Recordings

Ci failure screenshot: notice how, after clicking the ENS address button, we don't see the asset below, this means that the click didn't have any effect.

Expected: after clicking the EN address button, we should see the asset below

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Extension Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
• [ ]