Skip to content

chore: add Non-EVM feature flag#25241

Merged
gantunesr merged 2 commits intodevelopfrom
chore/btc-feature-flag
Jun 12, 2024
Merged

chore: add Non-EVM feature flag#25241
gantunesr merged 2 commits intodevelopfrom
chore/btc-feature-flag

Conversation

@gantunesr
Copy link
Copy Markdown
Member

@gantunesr gantunesr commented Jun 12, 2024

Description

Open in GitHub Codespaces

This PR adds a feature flag to be used during the development of the non-EVM initiative. To use the flag during development just change the value of the flag to true and access it using process.env.BTC_BETA_SUPPORT.

Related issues

Fixes: https://github.com/MetaMask/accounts-planning/issues/466

Manual testing steps

No manual testing required

Screenshots/Recordings

Not applicable

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@gantunesr gantunesr added the team-accounts-framework Accounts team label Jun 12, 2024
@gantunesr gantunesr self-assigned this Jun 12, 2024
@gantunesr gantunesr marked this pull request as ready for review June 12, 2024 04:31
@gantunesr gantunesr requested a review from a team as a code owner June 12, 2024 04:31
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [b52373a]
Page Load Metrics (124 ± 161 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6710780105
domContentLoaded9121010
load401583124335161
domInteractive9121010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@gantunesr gantunesr merged commit 8fabd54 into develop Jun 12, 2024
@gantunesr gantunesr deleted the chore/btc-feature-flag branch June 12, 2024 15:06
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-accounts-framework Accounts team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants