Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25220 +/- ##
========================================
Coverage 65.64% 65.64%
========================================
Files 1367 1367
Lines 54257 54257
Branches 14189 14189
========================================
Hits 35616 35616
Misses 18641 18641 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [3a213b5]
Page Load Metrics (52 ± 3 ms)
Bundle size diffs
|
seaona
commented
Jun 12, 2024
| await logInWithBalanceValidation(driver, ganacheServer); | ||
|
|
||
| // Wait for balance to load | ||
| await driver.delay(500); |
Member
Author
There was a problem hiding this comment.
this is not needed as we already apply the logInWithBalanceValidation
DDDDDanica
approved these changes
Jun 12, 2024
vthomas13
approved these changes
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The problem with this flaky test is that we start a send flow (type 0x0 tx), and we are switching assets (from NFT to ETH) and proceeding to the next screen, if we click Continue before the gasLimit is updated the test will fail: once we land into the last confirmation screen, the gas limit is never updated there, so the test fails as the total value doesn't match with the expected one.
This is a race condition that happens on the wallet level, but this PR intends to fix the flakiness on the test level to not wait for the fix on the wallet side.
See bug here.
To fix this, we could either add a delay, or in this case, we add some extra validation (making sure the hex data is cleared) and update the transaction values, to trigger again a gas update.
Related issues
Fixes: #25181
Manual testing steps
FIREFOX_SNAP=true yarn test:e2e:single test/e2e/tests/transaction/change-assets.spec.js --browser=firefox --leave-running --retryUntilFailure --retries=10Screenshots/Recordings
gaslimit-asset-old.mp4
Pre-merge author checklist
Pre-merge reviewer checklist