fix: add deprecated tag back to callBackgroundMethod#25216
Merged
DDDDDanica merged 3 commits intodevelopfrom Jun 11, 2024
Merged
fix: add deprecated tag back to callBackgroundMethod#25216DDDDDanica merged 3 commits intodevelopfrom
DDDDDanica merged 3 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
pedronfigueiredo
previously approved these changes
Jun 11, 2024
hjetpoluru
previously approved these changes
Jun 11, 2024
Gudahtt
reviewed
Jun 11, 2024
1151da3
3492df6 to
1151da3
Compare
Gudahtt
reviewed
Jun 11, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25216 +/- ##
========================================
Coverage 65.59% 65.59%
========================================
Files 1362 1362
Lines 54167 54167
Branches 14167 14167
========================================
Hits 35527 35527
Misses 18640 18640 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [1151da3]
Page Load Metrics (45 ± 4 ms)
Bundle size diffs
|
pedronfigueiredo
approved these changes
Jun 11, 2024
albertolive
approved these changes
Jun 11, 2024
Collaborator
Builds ready [5405fb3]
Page Load Metrics (137 ± 170 ms)
Bundle size diffs
|
vthomas13
approved these changes
Jun 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removed wrongly in #21410, this PR aims to add
deprecatedtag back tocallBackgroundMethodfor migration purpose.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist