Skip to content

v12.0.0 Cherry-Pick fix: Avoid to send the snap notification id to the notifications serv…#25215

Merged
hjetpoluru merged 1 commit intoVersion-v12.0.0from
v12.0.0/cherry-pick-7eaf6b73caddfa54d22a602c30ca323a56ec6bda
Jun 12, 2024
Merged

v12.0.0 Cherry-Pick fix: Avoid to send the snap notification id to the notifications serv…#25215
hjetpoluru merged 1 commit intoVersion-v12.0.0from
v12.0.0/cherry-pick-7eaf6b73caddfa54d22a602c30ca323a56ec6bda

Conversation

@matteoscurati
Copy link
Copy Markdown
Contributor

@matteoscurati matteoscurati commented Jun 11, 2024

Description

This PR fixes a bug related to the "Mark all notifications as read" button. The button is responsible, when clicked, for performing the actions to mark a notification as read. In the case of on-chain notifications, this state needs to be saved via API on the notification server. The PR prevents the IDs of SNAP notifications from being sent to the server, as their read/unread state is managed differently.

Original PR: #25099
This Cherry-Pick did not have any merge conflicts that needed resolving.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…er (#25099)

## **Description**

This PR fixes a bug related to the "Mark all notifications as read"
button. The button is responsible, when clicked, for performing the
actions to mark a notification as read. In the case of on-chain
notifications, this state needs to be saved via API on the notification
server. The PR prevents the IDs of SNAP notifications from being sent to
the server, as their read/unread state is managed differently.

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25099?quickstart=1)

## **Related issues**

Fixes:

## **Manual testing steps**

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [x] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@matteoscurati matteoscurati marked this pull request as ready for review June 11, 2024 12:11
@matteoscurati matteoscurati requested a review from a team as a code owner June 11, 2024 12:11
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@matteoscurati matteoscurati added the team-notifications-deprecated DEPRECATED: please use "team-assets" instead label Jun 11, 2024
@Prithpal-Sooriya Prithpal-Sooriya changed the title fix: Avoid to send the snap notification id to the notifications serv… v12.0.0 Cherry-Pick fix: Avoid to send the snap notification id to the notifications serv… Jun 12, 2024
@hjetpoluru hjetpoluru merged commit cbb3544 into Version-v12.0.0 Jun 12, 2024
@hjetpoluru hjetpoluru deleted the v12.0.0/cherry-pick-7eaf6b73caddfa54d22a602c30ca323a56ec6bda branch June 12, 2024 16:19
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2024
@metamaskbot metamaskbot added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 12, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-12.0.0 on PR, as PR was cherry-picked in branch 12.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-notifications-deprecated DEPRECATED: please use "team-assets" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants