feat(multichain): add new selectors#25205
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
69ec7b2 to
57d5dbf
Compare
montelaidev
reviewed
Jun 11, 2024
Collaborator
Builds ready [57d5dbf]
Page Load Metrics (44 ± 2 ms)
Bundle size diffs
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25205 +/- ##
===========================================
+ Coverage 65.59% 65.61% +0.02%
===========================================
Files 1362 1364 +2
Lines 54167 54219 +52
Branches 14167 14180 +13
===========================================
+ Hits 35527 35572 +45
- Misses 18640 18647 +7 ☔ View full report in Codecov by Sentry. |
gantunesr
approved these changes
Jun 11, 2024
montelaidev
approved these changes
Jun 11, 2024
Collaborator
Builds ready [2ede63f]
Page Load Metrics (40 ± 2 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds new selectors for multichain context (and more specifically, for non-EVM networks for now).
Those selectors follow the same naming than some existing selectors (that are EVM only).
Related issues
None
Manual testing steps
This PR only adds new selectors, this change can't be manually tested.
Screenshots/Recordings
Not applicable
Pre-merge author checklist
Pre-merge reviewer checklist