Skip to content

fix: tx-controller / nonce-tracker fix#25188

Closed
legobeat wants to merge 8 commits intoMetaMask:developfrom
legobeat:deps-transaction-controller-33
Closed

fix: tx-controller / nonce-tracker fix#25188
legobeat wants to merge 8 commits intoMetaMask:developfrom
legobeat:deps-transaction-controller-33

Conversation

@legobeat
Copy link
Copy Markdown
Contributor

@legobeat legobeat commented Jun 10, 2024 •
edited
Loading

Description

Using builds from MetaMask/core#4412

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 10, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@socket-security
Copy link
Copy Markdown

socket-security bot commented Jun 10, 2024 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/@metamask-previews/network-controller@19.0.0-preview-24c396ed None 0 0 B
npm/@metamask/network-controller@19.0.0-preview-24c396ed None 0 0 B

🚮 Removed packages: npm/@metamask/transaction-controller@32.0.0

View full report↗︎

@legobeat legobeat mentioned this pull request Jun 10, 2024
Closed
6 tasks
@legobeat legobeat force-pushed the deps-transaction-controller-33 branch from 7b81cb8 to 44e4714 Compare June 11, 2024 03:10
@hesterbruikman hesterbruikman mentioned this pull request Jun 11, 2024
Closed
@legobeat
Copy link
Copy Markdown
Contributor Author

legobeat commented Jun 12, 2024

@metamaskbot publish-preview

@legobeat legobeat force-pushed the deps-transaction-controller-33 branch from 233337d to 541cb89 Compare June 12, 2024 03:30
@legobeat legobeat changed the title tx-controller / nonce-tracker fix fix: tx-controller / nonce-tracker fix Jun 12, 2024
@legobeat legobeat added type-bug Something isn't working dependencies Pull requests that update a dependency file team-application-security Application security team regression-main Regression bug that was found on main branch, but not yet present in production labels Jun 12, 2024
@legobeat legobeat force-pushed the deps-transaction-controller-33 branch from ca29b86 to d3db783 Compare June 13, 2024 20:19
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 12, 2024

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Aug 12, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Aug 26, 2024

This PR was closed because there has been no follow up activity in the last 14 days. Thank you for your contributions.

@github-actions github-actions bot closed this Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file regression-main Regression bug that was found on main branch, but not yet present in production stale issues and PRs marked as stale team-application-security Application security team type-bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@legobeat