Skip to content

v12.0.0 Cherry-Pick Notifications Feature Disabled when Basic Functionality Off#25184

Merged
danjm merged 1 commit intoVersion-v12.0.0from
v12.0.0/cherry-pick-556b43fb85605e33a01c3ed68da5b2092a85e8c9
Jun 11, 2024
Merged

v12.0.0 Cherry-Pick Notifications Feature Disabled when Basic Functionality Off#25184
danjm merged 1 commit intoVersion-v12.0.0from
v12.0.0/cherry-pick-556b43fb85605e33a01c3ed68da5b2092a85e8c9

Conversation

@Prithpal-Sooriya
Copy link
Copy Markdown
Contributor

@Prithpal-Sooriya Prithpal-Sooriya commented Jun 10, 2024

Description

Ensures that notifications are disabled and the menu is hidden when basic functionality if off (prevents additional API calls and any weird states a user could get into when basic functionality if off).

PR: #25070
Commit Hash: 556b43fb85605e33a01c3ed68da5b2092a85e8c9

There were no merge conflicts when picking these commits.

Open in GitHub Codespaces

Related issues

Fixes: The current Profile Syncing Feature doesn't fully respect Basic Functionality when turned off. This ensures that the notifications feature and profile syncing are actually turned off when Basic Functionality if off.

Manual testing steps

  1. Go to this page... 2.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

…hen no basic functionality (#25070)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

This ensures that our feature is fully disabled when the basic
functionality is disabled.
This is mostly a Hot-Fix, and a more structured UX/UI will be available
once discussed with design and product.

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/25070?quickstart=1)

## **Related issues**

Fixes: The current Profile Syncing Feature doesn't fully respect Basic
Functionality when turned off. This ensures that the notifications
feature and profile syncing are actually turned off when Basic
Functionality if off.

## **Manual testing steps**

1. Go to this page...
2.
3.

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

Updated/Fixed Onboarding flow for Basic Functionality + Profile Syncing
[See vid

](https://www.loom.com/share/0cae6cabcba24e41ba3d933b5676ef32?sid=9f8448c1-7bbf-4af6-821f-861979ae01d7)

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@Prithpal-Sooriya Prithpal-Sooriya added the team-notifications-deprecated DEPRECATED: please use "team-assets" instead label Jun 10, 2024
@Prithpal-Sooriya Prithpal-Sooriya requested review from a team as code owners June 10, 2024 16:56
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [bccb133]
Page Load Metrics (50 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint69968194
domContentLoaded9171021
load42705074
domInteractive9171021
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 5.93 KiB (0.09%)
  • common: 3.38 KiB (0.05%)

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 78.72340% with 10 lines in your changes missing coverage. Please review.

Project coverage is 65.60%. Comparing base (fab8cb5) to head (bccb133).

Files Patch % Lines
...boarding-flow/privacy-settings/privacy-settings.js 77.27% 5 Missing ⚠️
...i/components/multichain/global-menu/global-menu.js 33.33% 4 Missing ⚠️
...ty-tab/profile-sync-toggle/profile-sync-toggle.tsx 87.50% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           Version-v12.0.0   #25184      +/-   ##
===================================================
+ Coverage            65.59%   65.60%   +0.01%     
===================================================
  Files                 1359     1359              
  Lines                54148    54169      +21     
  Branches             14091    14098       +7     
===================================================
+ Hits                 35516    35537      +21     
  Misses               18632    18632              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@danjm danjm merged commit 1d8fa4e into Version-v12.0.0 Jun 11, 2024
@danjm danjm deleted the v12.0.0/cherry-pick-556b43fb85605e33a01c3ed68da5b2092a85e8c9 branch June 11, 2024 19:28
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
@metamaskbot metamaskbot added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 11, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-12.0.0 on PR, as PR was cherry-picked in branch 12.0.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-notifications-deprecated DEPRECATED: please use "team-assets" instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants