Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25143 +/- ##
===========================================
- Coverage 65.64% 65.64% -0.00%
===========================================
Files 1367 1370 +3
Lines 54257 54281 +24
Branches 14189 14199 +10
===========================================
+ Hits 35616 35630 +14
- Misses 18641 18651 +10 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [03c423c]
Page Load Metrics (129 ± 148 ms)
Bundle size diffs
|
03c423c to
e4e9424
Compare
gantunesr
previously approved these changes
Jun 11, 2024
Collaborator
Builds ready [594ba76]
Page Load Metrics (305 ± 393 ms)
Bundle size diffs
|
ccharly
approved these changes
Jun 12, 2024
Contributor
ccharly
left a comment
There was a problem hiding this comment.
LGTM, I strongly rely on the snapshots being the same as the original AppHeader here.
One small note (that could be addressed in another PR), since this PR moves from .js to .ts, some new typing issues arise, and we repeat this pattern a lot: field={currentNetwork?.field ?? ''
So it would be great if we could rewrite those in a more DRY way like:
const currentNetworkNickname = currentNetwork?.nickname ?? '';
<Component
label={currentNetworkNickname}
/>
gantunesr
approved these changes
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the app header into smaller components and adds multichain selectors.
Related issues
Related to https://github.com/MetaMask/accounts-planning/issues/425
Manual testing steps
Screenshots/Recordings
Just an UI/UX components refactor. No changes.
Pre-merge author checklist
Pre-merge reviewer checklist