Description

Pulls this fix which adds a guard to the setNetworkClientIdForDomain method on the SelectedNetworkController to no longer add domains to domains state (nor create a selected network proxy for them) unless the useRequestQueuePreference flag is true

Bumping the @metamask/selected-network-controller version required bumping peer dependencies:

• @metamask/network-controller to v19.0.0
  • An existing patch was repointed to this version.
• @metamask/permission-controller to v10.0.0
  - This required bumping its own peerDep @metamask/approval-controller to v7.0.0

Related issues

See: https://consensys.slack.com/archives/C1L7H42BT/p1717512150509719

Manual testing steps

1. Open settings -> experimental and toggle of the Select networks for each site setting
2. Go to any site
3. Open the console and execute:

await window.ethereum.request({
  "method": "eth_chainId",
  "params": []
});

4. See that it matches the globally selected network
5. Manually change the network with the network switcher
6. Go back to the site and execute the same eth_chainId script
7. See that the result has changed to the chainId you switched to
8. Now execute

await window.ethereum.request({
  "method": "wallet_requestPermissions",
  "params": [
    {
      "eth_accounts": {}
    }
  ]
});

and connect an account to the site
9. Repeat steps 1 - 7
10. The eth_chainId results should still match the globally selected network

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.