fix: add metrics ui_customizations: permit for permit signature types#25105
Merged
fix: add metrics ui_customizations: permit for permit signature types#25105
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
matthewwalsh0
previously approved these changes
Jun 7, 2024
91ee72e to
010a1e0
Compare
21fb8cd to
787289a
Compare
010a1e0 to
feb8367
Compare
feb8367 to
228f73b
Compare
787289a to
dbba668
Compare
digiwand
reviewed
Jun 12, 2024
Comment on lines
+285
to
+286
| export const parseTypedDataMessage = (dataToParse: string) => | ||
| JSON.parse(dataToParse); |
Contributor
There was a problem hiding this comment.
IIRC, there was a conversation about utilizing this separate function with JSON.parse to elaborate on the expected parsed values
digiwand
approved these changes
Jun 12, 2024
Collaborator
Builds ready [679d0bf]
Page Load Metrics (119 ± 146 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25105 +/- ##
===========================================
+ Coverage 65.66% 65.67% +0.01%
===========================================
Files 1371 1371
Lines 54328 54337 +9
Branches 14217 14216 -1
===========================================
+ Hits 35673 35684 +11
+ Misses 18655 18653 -2 ☔ View full report in Codecov by Sentry. |
pedronfigueiredo
approved these changes
Jun 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add metrics
ui_customisation: [permit]for permit signature typeRelated issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/2585
Manual testing steps
ui_customisation: [permit]Screenshots/Recordings
NA
Pre-merge author checklist
Pre-merge reviewer checklist