Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
6a1c6ef to
a93a691
Compare
micaelae
reviewed
Jun 7, 2024
ui/components/multichain/asset-picker-amount/asset-picker-modal/AssetList.tsx
Outdated
Show resolved
Hide resolved
micaelae
reviewed
Jun 7, 2024
ui/components/multichain/asset-picker-amount/asset-picker-modal/AssetList.tsx
Outdated
Show resolved
Hide resolved
added 17 commits
June 7, 2024 16:24
fixes 24922
fixes 25015
fixes 25133
fixes 24505
ejwessel
previously approved these changes
Jun 7, 2024
ejwessel
previously approved these changes
Jun 7, 2024
micaelae
reviewed
Jun 7, 2024
micaelae
reviewed
Jun 7, 2024
Comment on lines
+89
to
+92
| setTimeout(() => { | ||
| this.unitInput.scrollLeft = this.unitInput.scrollWidth; | ||
| }, 0); | ||
|
|
Member
There was a problem hiding this comment.
what does this do?
seeing some odd behavior when I enter a long number like 0.12414314125153525326236. only the ending numbers are displayed on unfocus. also happens when I hit Max and my balance has a lot of trailing numbers
added 2 commits
June 7, 2024 18:50
micaelae
approved these changes
Jun 7, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #25100 +/- ##
========================================
Coverage 65.64% 65.64%
========================================
Files 1362 1362
Lines 54151 54189 +38
Branches 14074 14112 +38
========================================
+ Hits 35546 35572 +26
- Misses 18605 18617 +12 ☔ View full report in Codecov by Sentry. |
sleepytanya
approved these changes
Jun 7, 2024
Collaborator
Builds ready [d6536aa]
Page Load Metrics (118 ± 157 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A number of minor bugs have been discovered during the official QA process of Swap+Send; this PR aims to resolve all of them without regression.
Related issues
METABRIDGE-843
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist