Skip to content

chore: add swap+send analytics#25078

Merged
BZahory merged 14 commits intodevelopfrom
mb843/analytics
Jun 7, 2024
Merged

chore: add swap+send analytics#25078
BZahory merged 14 commits intodevelopfrom
mb843/analytics

Conversation

@BZahory
Copy link
Copy Markdown
Contributor

@BZahory BZahory commented Jun 5, 2024 •
edited by github-actions bot
Loading

Description

This PR introduces the new analytics events for Swap+Send; it also improves analytics for the existing flow.

Open in GitHub Codespaces

Related issues

METABRIDGE-843

Fixes:

Manual testing steps

  1. Mock analytics to log in console
  2. Ensure all analytics modified/added are firing as expected

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@BZahory BZahory requested review from a team as code owners June 5, 2024 18:34
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

micaelae
micaelae previously approved these changes Jun 5, 2024
View reviewed changes
@BZahory BZahory force-pushed the mb843/analytics branch from d6f8234 to 8dcb50f Compare June 5, 2024 23:25
ejwessel
ejwessel previously approved these changes Jun 5, 2024
View reviewed changes
@BZahory BZahory force-pushed the mb843/analytics branch from 8dcb50f to ae340a8 Compare June 5, 2024 23:44
@BZahory BZahory added the team-bridge-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead label Jun 5, 2024
micaelae
micaelae previously approved these changes Jun 6, 2024
View reviewed changes
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 6, 2024

Builds ready [76b2daa]
Page Load Metrics (46 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6310677105
domContentLoaded811910
load40724694
domInteractive811910
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 4.58 KiB (0.07%)
  • common: 2.33 KiB (0.04%)

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 77.14286% with 16 lines in your changes missing coverage. Please review.

Project coverage is 65.64%. Comparing base (267c24b) to head (a93a691).

Files Patch % Lines
ui/ducks/send/send.js 81.82% 6 Missing ⚠️
.../asset-picker-amount/asset-picker/asset-picker.tsx 40.00% 3 Missing ⚠️
ui/components/multichain/pages/send/send.js 75.00% 2 Missing ⚠️
ui/components/app/nfts-items/nfts-items.js 66.67% 1 Missing ⚠️
...r-amount/asset-picker-modal/asset-picker-modal.tsx 75.00% 1 Missing ⚠️
.../multichain/pages/send/components/address-book.tsx 50.00% 1 Missing ⚠️
...ltichain/pages/send/components/recipient-input.tsx 0.00% 1 Missing ⚠️
...nts/multichain/pages/send/components/recipient.tsx 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25078   +/-   ##
========================================
  Coverage    65.64%   65.64%           
========================================
  Files         1362     1362           
  Lines        54080    54154   +74     
  Branches     14027    14073   +46     
========================================
+ Hits         35499    35549   +50     
- Misses       18581    18605   +24

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BZahory BZahory changed the base branch from develop to mb843-blocked-tokens-update June 6, 2024 13:58
@BZahory BZahory requested review from a team as code owners June 6, 2024 13:58
@BZahory BZahory changed the base branch from mb843-blocked-tokens-update to develop June 6, 2024 13:59
@BZahory BZahory dismissed micaelae’s stale review June 6, 2024 13:59

The base branch was changed.

ejwessel
ejwessel previously approved these changes Jun 6, 2024
View reviewed changes
@BZahory BZahory force-pushed the mb843/analytics branch from 76b2daa to 6a1c6ef Compare June 7, 2024 18:33
@BZahory BZahory force-pushed the mb843/analytics branch from 6a1c6ef to a93a691 Compare June 7, 2024 18:55
@BZahory BZahory merged commit 90f7c59 into develop Jun 7, 2024
@BZahory BZahory deleted the mb843/analytics branch June 7, 2024 19:19
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ejwessel ejwessel ejwessel approved these changes

@micaelae micaelae micaelae approved these changes

Assignees

No one assigned

Labels

release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-bridge-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@BZahory @metamaskbot @ejwessel @micaelae