Skip to content

feat: adding pluggable section to confirmation page#25061

Merged
jpuri merged 7 commits intodevelopfrom
confirm_page_pluggable_section
Jun 11, 2024
Merged

feat: adding pluggable section to confirmation page#25061
jpuri merged 7 commits intodevelopfrom
confirm_page_pluggable_section

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Jun 5, 2024

Description

Adding pluggable section on confirmation page.

Related issues

Fixes: #24996

Manual testing steps

NA

Screenshots/Recordings

NA

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) confirmation-redesign team-confirmations Push issues to confirmations team labels Jun 5, 2024
@jpuri jpuri requested a review from a team as a code owner June 5, 2024 12:47
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

matthewwalsh0
matthewwalsh0 reviewed Jun 6, 2024
View reviewed changes
@jpuri jpuri requested a review from matthewwalsh0 June 7, 2024 07:51
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 7, 2024

Builds ready [6789f98]
Page Load Metrics (50 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint681058184
domContentLoaded8141021
load42805094
domInteractive8141021
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.77 KiB (0.03%)
  • common: 0 Bytes (0.00%)

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.72%. Comparing base (47706eb) to head (8c2312c).
Report is 24 commits behind head on develop.

Files Patch % Lines
...ts/confirm/pluggable-section/pluggable-section.tsx 80.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #25061   +/-   ##
========================================
  Coverage    65.72%   65.72%           
========================================
  Files         1360     1361    +1     
  Lines        54043    54048    +5     
  Branches     14036    14036           
========================================
+ Hits         35518    35522    +4     
- Misses       18525    18526    +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 7, 2024

Builds ready [8c2312c]
Page Load Metrics (57 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7510991105
domContentLoaded9271352
load46755784
domInteractive9271352
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.77 KiB (0.03%)
  • common: 0 Bytes (0.00%)

@jpuri jpuri merged commit c23654d into develop Jun 11, 2024
@jpuri jpuri deleted the confirm_page_pluggable_section branch June 11, 2024 12:22
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 11, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

Assignees

No one assigned

Labels

confirmation-redesign release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-confirmations Push issues to confirmations team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add pluggable section container on re-designed confirmation page

4 participants

@jpuri @metamaskbot @pedronfigueiredo @matthewwalsh0