Skip to content

fix: updates MMI e2e confirm transaction flow#25053

Merged
zone-live merged 3 commits intodevelopfrom
MMI-5093-fix-e2e-tests-flow
Jun 11, 2024
Merged

fix: updates MMI e2e confirm transaction flow#25053
zone-live merged 3 commits intodevelopfrom
MMI-5093-fix-e2e-tests-flow

Conversation

@zone-live
Copy link
Copy Markdown
Contributor

Description

Updates MMI e2e tests for the transaction confirmation flow.

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@zone-live zone-live requested a review from a team as a code owner June 5, 2024 09:29
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Jun 5, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@zone-live zone-live added the mmi DEPRECATED: The product got sunset label Jun 5, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [0334427]
Page Load Metrics (49 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint691048394
domContentLoaded9131010
load41774984
domInteractive9121010
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live requested a review from albertolive June 5, 2024 11:14
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [aa8394e]
Page Load Metrics (237 ± 277 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint57138812010
domContentLoaded7251253
load372256237576277
domInteractive7251252
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@zone-live zone-live merged commit 832ae1c into develop Jun 11, 2024
@zone-live zone-live deleted the MMI-5093-fix-e2e-tests-flow branch June 11, 2024 13:43
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

mmi DEPRECATED: The product got sunset release-12.1.0 Issue or pull request that will be included in release 12.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants