chore: add bridge controller, store and api utils by micaelae · Pull Request #25044 · MetaMask/metamask-extension

micaelae · 2024-06-05T00:03:42Z

Description

This PR doesn't have user-facing effects, just setting up state management for subsequent feature PRs.

Changes include

a new bridge controller that manages background state for the cross-chain swaps experience
basic redux slice for bridging. Note that the slice extends swaps, since we plan to decouple the frontend components for now but merge the experiences later on
e2e tests for current bridge button behavior
new logic for fetching and setting bridge feature flags

Related issues

Fixes: METABRIDGE-889

Manual testing steps

Load extension
Verify that Bridge button behavior has not changed

Screenshots/Recordings

Before

After

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
[] I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

metamaskbot · 2024-06-25T21:38:43Z

Builds ready [581e6b7]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (44 ± 3 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	61	101	76	9	4
		domContentLoaded	8	13	10	1	1
		load	39	61	44	6	3
		domInteractive	8	13	10	1	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.61 KiB (0.05%)
ui: 798 Bytes (0.01%)
common: 313 Bytes (0.00%)

ui/hooks/experiences/useBridging.ts

ui/pages/bridge/bridge.util.ts

metamaskbot · 2024-06-27T02:15:26Z

Builds ready [5d90ab0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (149 ± 197 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	204	91	29	14
		domContentLoaded	9	15	11	1	1
		load	40	1938	149	411	197
		domInteractive	9	15	11	1	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.61 KiB (0.05%)
ui: 798 Bytes (0.01%)
common: 363 Bytes (0.01%)

metamaskbot · 2024-06-27T02:30:16Z

Builds ready [5d90ab0]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (149 ± 197 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	204	91	29	14
		domContentLoaded	9	15	11	1	1
		load	40	1938	149	411	197
		domInteractive	9	15	11	1	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.61 KiB (0.05%)
ui: 798 Bytes (0.01%)
common: 363 Bytes (0.01%)

codecov · 2024-06-28T19:12:59Z

Codecov Report

Attention: Patch coverage is 82.92683% with 7 lines in your changes missing coverage. Please review.

Project coverage is 69.58%. Comparing base (4a9c480) to head (3bbb6eb).

Files	Patch %	Lines
ui/hooks/bridge/useBridging.ts	0.00%	5 Missing ⚠️
app/scripts/controllers/bridge.ts	85.71%	1 Missing ⚠️
shared/constants/bridge.ts	83.33%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #25044      +/-   ##
===========================================
+ Coverage    69.57%   69.58%   +0.01%     
===========================================
  Files         1360     1365       +5     
  Lines        48172    48213      +41     
  Branches     13296    13299       +3     
===========================================
+ Hits         33513    33548      +35     
- Misses       14659    14665       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-06-28T19:24:28Z

Builds ready [3bbb6eb]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (68 ± 9 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	68	157	95	19	9
		domContentLoaded	10	80	27	15	7
		load	49	130	68	18	9
		domInteractive	10	80	27	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 1.61 KiB (0.05%)
ui: 798 Bytes (0.01%)
common: 363 Bytes (0.01%)

micaelae requested review from a team as code owners June 5, 2024 00:03

micaelae marked this pull request as draft June 5, 2024 00:03

micaelae force-pushed the mb889-bridge-controller branch 12 times, most recently from 1dccfa0 to 2598383 Compare June 8, 2024 00:42

micaelae force-pushed the mb889-bridge-controller branch 14 times, most recently from 32dd55f to 512636b Compare June 19, 2024 01:23

micaelae force-pushed the mb889-bridge-controller branch from ab9fd63 to 581e6b7 Compare June 25, 2024 20:44

BZahory reviewed Jun 26, 2024

View reviewed changes

ui/hooks/experiences/useBridging.ts Outdated Show resolved Hide resolved

BZahory reviewed Jun 26, 2024

View reviewed changes

ui/pages/bridge/bridge.util.ts Outdated Show resolved Hide resolved

BZahory reviewed Jun 26, 2024

View reviewed changes

ui/pages/bridge/bridge.util.ts Outdated Show resolved Hide resolved

BZahory reviewed Jun 26, 2024

View reviewed changes

ui/pages/bridge/bridge.util.ts Outdated Show resolved Hide resolved

BZahory previously approved these changes Jun 26, 2024

View reviewed changes

micaelae force-pushed the mb889-bridge-controller branch from 2cf440c to 5d90ab0 Compare June 26, 2024 19:13

micaelae removed the request for review from a team June 26, 2024 19:14

ejwessel previously approved these changes Jun 26, 2024

View reviewed changes

micaelae force-pushed the mb889-bridge-controller branch from 5d90ab0 to 574eaa6 Compare June 27, 2024 02:14

micaelae dismissed stale reviews from BZahory and ejwessel via 4ecb621 June 27, 2024 18:06

micaelae added 6 commits June 28, 2024 11:38

chore: bridge slice that extends swaps slice

8c0aae8

chore: bridge controller skeleton

723eea5

chore: fetch and set bridgeFeatureFlags in the background

73c32fd

test: add bridge e2e tests

27deb5a

chore: update constants

d07a16e

fix: any types

3bbb6eb

micaelae force-pushed the mb889-bridge-controller branch from 4ecb621 to 3bbb6eb Compare June 28, 2024 18:53

BZahory approved these changes Jun 28, 2024

View reviewed changes

ejwessel approved these changes Jun 28, 2024

View reviewed changes

micaelae merged commit 58082f5 into develop Jun 28, 2024

micaelae deleted the mb889-bridge-controller branch June 28, 2024 21:31

github-actions bot locked and limited conversation to collaborators Jun 28, 2024

metamaskbot added the release-12.2.0 Issue or pull request that will be included in release 12.2.0 label Jun 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: add bridge controller, store and api utils#25044

chore: add bridge controller, store and api utils#25044
micaelae merged 6 commits intodevelopfrom
mb889-bridge-controller

micaelae commented Jun 5, 2024 •

edited

Loading

Uh oh!

metamaskbot commented Jun 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Jun 27, 2024

Uh oh!

metamaskbot commented Jun 27, 2024

Uh oh!

codecov bot commented Jun 28, 2024

Uh oh!

metamaskbot commented Jun 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

micaelae commented Jun 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

metamaskbot commented Jun 25, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Jun 27, 2024

Uh oh!

metamaskbot commented Jun 27, 2024

Uh oh!

codecov bot commented Jun 28, 2024

Codecov Report

Uh oh!

metamaskbot commented Jun 28, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

micaelae commented Jun 5, 2024 •

edited

Loading