Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
e077f36 to
11bc0cf
Compare
vthomas13
commented
Jun 10, 2024
| } | ||
| }; | ||
|
|
||
| element.nestedFindElement = async (rawLocator) => { |
Contributor
Author
There was a problem hiding this comment.
I think this is somewhat inconsistent with the other webdriver methods for finding elements:
[findElement(s), findClickableElement(s), findVisibleElement, etc.]
vthomas13
commented
Jun 10, 2024
| * @param {string | object} nestedLocator - Nested element locator | ||
| * @returns {Promise<WebElement>} A promise that resolves to the found nested element. | ||
| */ | ||
| async findNestedElement(element, nestedLocator) { |
Contributor
Author
There was a problem hiding this comment.
Same file, slightly different name, added docs
DDDDDanica
approved these changes
Jun 10, 2024
Contributor
|
LGTM ! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #25041 +/- ##
========================================
Coverage 65.59% 65.59%
========================================
Files 1363 1363
Lines 54172 54172
Branches 14167 14167
========================================
Hits 35531 35531
Misses 18641 18641 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [11bc0cf]
Page Load Metrics (119 ± 138 ms)
Bundle size diffs
|
This reverts commit ee163df8d1d251fa442dbfac29c9c9db106b3817.
11bc0cf to
46faec1
Compare
Collaborator
Builds ready [46faec1]
Page Load Metrics (47 ± 2 ms)
Bundle size diffs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is a fix for the flakiness in the e2e test case: "Swap-Send ERC20 to non-contract address with data that matches swap data signature submits a transaction successfully"
Additionally there are some minor readability improvements.
Related issues
Fixes: #25026
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist