Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
HowardBraham
approved these changes
May 31, 2024
Contributor
HowardBraham
left a comment
There was a problem hiding this comment.
This is good, this shouldn't be navigating anyway, even if we fix the larger Sentry problem
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24926 +/- ##
========================================
Coverage 65.85% 65.85%
========================================
Files 1363 1363
Lines 54254 54254
Branches 14114 14114
========================================
Hits 35725 35725
Misses 18529 18529 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [09b74f2]
Page Load Metrics (204 ± 271 ms)
Bundle size diffs
|
danjm
approved these changes
May 31, 2024
Collaborator
|
Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On very slow machines the "Import flow @no-mmi Import wallet using Secret Recovery Phrase" test can fail with an error, as seen here: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/83747/workflows/b71850d1-d6fb-484d-8666-1ed6b4222308/jobs/3002940/parallel-runs/1?invite=true#step-104-1600
This change works around the bug by avoiding the extraneous call to
driver.navigate()that was sometimes triggering a call to out to sentry (that would be then be immediately cancelled, which causes the exception to be raised).This doesn't fix the root of the problem (if there is one), but it works around the issue in a way that won't affect any or get in the way of a future "fix" (I don't think this is really a bug, but just an issue with our tests).