Skip to content

fix: re-enable swap-send-eth e2e test#24882

Merged
micaelae merged 3 commits intodevelopfrom
mb843-fix-swap-send-eth-e2e
Jun 7, 2024
Merged

fix: re-enable swap-send-eth e2e test#24882
micaelae merged 3 commits intodevelopfrom
mb843-fix-swap-send-eth-e2e

Conversation

@micaelae
Copy link
Copy Markdown
Member

@micaelae micaelae commented May 29, 2024 •
edited by github-actions bot
Loading

Description

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@micaelae micaelae requested review from a team as code owners May 29, 2024 20:54
@micaelae micaelae requested review from BZahory and ejwessel May 29, 2024 20:55
@micaelae micaelae force-pushed the mb843-fix-swap-send-eth-e2e branch 2 times, most recently from 313d8c9 to 4d8991c Compare June 3, 2024 20:56
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.64%. Comparing base (a2e6bcc) to head (d944dac).
Report is 3 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #24882   +/-   ##
========================================
  Coverage    65.64%   65.64%           
========================================
  Files         1362     1362           
  Lines        54083    54083           
  Branches     14027    14027           
========================================
  Hits         35502    35502           
  Misses       18581    18581

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@micaelae micaelae requested a review from a team as a code owner June 4, 2024 00:05
@micaelae micaelae force-pushed the mb843-fix-swap-send-eth-e2e branch 2 times, most recently from 74f0f70 to ffd3159 Compare June 4, 2024 01:08
@micaelae micaelae added the team-bridge-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead label Jun 4, 2024
@micaelae micaelae changed the title [METABRIDGE-843] fix: re-enable swap-send-eth e2e test fix: re-enable swap-send-eth e2e test Jun 4, 2024
@micaelae micaelae force-pushed the mb843-fix-swap-send-eth-e2e branch from ffd3159 to 813ea33 Compare June 4, 2024 16:55
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 4, 2024

Builds ready [813ea33]
Page Load Metrics (48 ± 4 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint64997774
domContentLoaded9161021
load41714884
domInteractive9161021
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 208 Bytes (0.00%)

@micaelae micaelae changed the base branch from develop to mb843-blocked-tokens-update June 4, 2024 18:56
@micaelae micaelae removed request for a team June 4, 2024 18:56
@micaelae micaelae force-pushed the mb843-fix-swap-send-eth-e2e branch 2 times, most recently from 7e1af7d to b0257aa Compare June 4, 2024 19:11
BZahory
BZahory previously approved these changes Jun 4, 2024
View reviewed changes
@micaelae micaelae force-pushed the mb843-fix-swap-send-eth-e2e branch from b0257aa to 6ffab20 Compare June 4, 2024 19:55
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 4, 2024

Builds ready [6ffab20]
Page Load Metrics (103 ± 121 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint64967784
domContentLoaded8181021
load401205103253121
domInteractive8181021
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 208 Bytes (0.00%)

@micaelae micaelae force-pushed the mb843-blocked-tokens-update branch from 1f0e90d to 04d9d5d Compare June 5, 2024 17:03
@micaelae micaelae force-pushed the mb843-fix-swap-send-eth-e2e branch from 6ffab20 to 4adc260 Compare June 5, 2024 17:49
@micaelae micaelae force-pushed the mb843-blocked-tokens-update branch from 04d9d5d to 2427c74 Compare June 5, 2024 21:04
@gauthierpetetin gauthierpetetin added release-12.0.0 Issue or pull request that will be included in release 12.0.0 and removed release-11.18.0 labels Jun 6, 2024
@micaelae micaelae force-pushed the mb843-blocked-tokens-update branch from f56c452 to 687d839 Compare June 6, 2024 18:47
Base automatically changed from mb843-blocked-tokens-update to develop June 7, 2024 17:33
@micaelae micaelae dismissed BZahory’s stale review June 7, 2024 17:33

The base branch was changed.

@micaelae micaelae force-pushed the mb843-fix-swap-send-eth-e2e branch from 4adc260 to d944dac Compare June 7, 2024 17:36
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented Jun 7, 2024

Builds ready [d944dac]
Page Load Metrics (137 ± 172 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6911386126
domContentLoaded9171121
load471700137359172
domInteractive9171121
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 47 Bytes (0.00%)

georgewrmarshall
georgewrmarshall approved these changes Jun 7, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Would you mind filling out the PR description for historical reference 🙏

@micaelae micaelae merged commit 267c24b into develop Jun 7, 2024
@micaelae micaelae deleted the mb843-fix-swap-send-eth-e2e branch June 7, 2024 18:53
@github-actions github-actions bot locked and limited conversation to collaborators Jun 7, 2024
@metamaskbot metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ejwessel ejwessel ejwessel approved these changes

@georgewrmarshall georgewrmarshall georgewrmarshall approved these changes

+1 more reviewer

@BZahory BZahory BZahory approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 release-12.1.0 Issue or pull request that will be included in release 12.1.0 team-bridge-deprecated DEPRECATED: please use "team-swaps-and-bridge" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@micaelae @metamaskbot @ejwessel @georgewrmarshall @BZahory @gauthierpetetin