Skip to content

test: Add a MetaMetricsDataDeletionController test#24879

Merged
Gudahtt merged 1 commit intodelete-metametrics-data-controllerfrom
delete-metametrics-data-controller-controller-tests
May 31, 2024
Merged

test: Add a MetaMetricsDataDeletionController test#24879
Gudahtt merged 1 commit intodelete-metametrics-data-controllerfrom
delete-metametrics-data-controller-controller-tests

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented May 29, 2024

Description

A single test has been added, along with a helper setup function that is designed to be used for further unit tests as well.

Open in GitHub Codespaces

Related issues

This is an improvement for the PR #24503

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

A single test has been added, along with a helper setup function that
is designed to be used for further unit tests as well.
@Gudahtt Gudahtt marked this pull request as ready for review May 29, 2024 19:45
@Gudahtt Gudahtt requested a review from a team as a code owner May 29, 2024 19:45
Copy link
Copy Markdown
Contributor

@NiranjanaBinoy NiranjanaBinoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@legobeat legobeat requested a review from NiranjanaBinoy May 31, 2024 03:53
@Gudahtt Gudahtt merged commit 57a1ad8 into delete-metametrics-data-controller May 31, 2024
@Gudahtt Gudahtt deleted the delete-metametrics-data-controller-controller-tests branch May 31, 2024 13:25
@github-actions github-actions bot locked and limited conversation to collaborators May 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants