refactor: Decouple the data deletion controller#24870
Merged
Gudahtt merged 3 commits intodelete-metametrics-data-controllerfrom May 29, 2024
Merged
refactor: Decouple the data deletion controller#24870Gudahtt merged 3 commits intodelete-metametrics-data-controllerfrom
Gudahtt merged 3 commits intodelete-metametrics-data-controllerfrom
Conversation
The `DataDeletionController` has been decoupled from the `MetaMetricsController` by updating the constructor parameters to expect just a function for getting the MetaMetrics ID, rather than the entire `MetaMetricsController` state. This vastly simplifies the API surface, making it easier to audit and test. It also prevents the `DataDeletionController` from having the capability to make changes to the `MetaMetricsController` state. This is an improvement for #24503
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## delete-metametrics-data-controller #24870 +/- ##
===================================================================
Coverage 65.74% 65.74%
===================================================================
Files 1368 1368
Lines 54335 54335
Branches 14124 14124
===================================================================
Hits 35722 35722
Misses 18613 18613 ☔ View full report in Codecov by Sentry. |
NiranjanaBinoy
approved these changes
May 29, 2024
Collaborator
Builds ready [c90863b]
Page Load Metrics (400 ± 370 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
DataDeletionControllerhas been decoupled from theMetaMetricsControllerby updating the constructor parameters to expect just a function for getting the MetaMetrics ID, rather than the entireMetaMetricsControllerstate. This vastly simplifies the API surface, making it easier to audit and test. It also prevents theDataDeletionControllerfrom having the capability to make changes to theMetaMetricsControllerstate.Related issues
This is an improvement for #24503
Manual testing steps
N/A
Screenshots/Recordings
N/A
Pre-merge author checklist
Pre-merge reviewer checklist