feat: permit signature simulation info by jpuri · Pull Request #24862 · MetaMask/metamask-extension

jpuri · 2024-05-29T12:23:45Z

Description

Add simulation section to permit signatures

Related issues

Fixes: #24618, #24878

Manual testing steps

Go to this test DAPP
Submit permit signature
Check that simulation section is present

Screenshots/Recordings

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

… permit_sign_info_section

github-actions · 2024-05-29T12:23:57Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

codecov · 2024-05-30T13:42:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.74%. Comparing base (a85b6cf) to head (9d17164).

❗ Current head 9d17164 differs from pull request most recent head 23f3050

Please upload reports for the commit 23f3050 to get more accurate results.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24862      +/-   ##
===========================================
+ Coverage    65.73%   65.74%   +0.02%     
===========================================
  Files         1369     1365       -4     
  Lines        54417    54274     -143     
  Branches     14161    14109      -52     
===========================================
- Hits         35766    35681      -85     
+ Misses       18651    18593      -58

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-05-30T14:14:19Z

Builds ready [11dc68b]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (888 ± 527 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	73	183	114	28	14
		domContentLoaded	10	23	13	3	2
		load	61	2574	888	1098	527
		domInteractive	10	23	13	3	2

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.27 KiB (0.05%)
common: 446 Bytes (0.01%)

…ion_info

metamaskbot · 2024-05-31T05:01:34Z

Builds ready [9d17164]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1674 ± 689 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	71	343	162	68	33
		domContentLoaded	10	69	24	15	7
		load	59	3309	1674	1435	689
		domInteractive	10	69	24	15	7

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 3.27 KiB (0.05%)
common: 134 Bytes (0.00%)

… permit_sign_info_section

…ion_info

digiwand · 2024-06-07T10:47:30Z

...ges/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx

+      </ConfirmInfoRow>
+    </Box>
+  );
+};


should the values be right aligned?

Hey @digiwand : after certain with confirm row wraps, thus this is how it will look for wider values

Derek had made some improvements on how we display long values within simulations here: #24036

Is this something we could re-use? Ideally, we have the same pattern in both places

Yep that can be done, but I would prefer to address that in separate PR.

digiwand · 2024-06-07T10:51:18Z

...ges/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx

+        </Box>
+      </ConfirmInfoRow>
+    </Box>
+  );


The pill component does not appear to be aligned with the label

Confirm info row are center aligned and its hard to change for this specifically

digiwand · 2024-06-07T10:55:20Z

...ges/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx

+    >
+      <ConfirmInfoRow
+        label={t('simulationDetailsTitle')}
+        tooltip={t('simulationDetailsTitleTooltip')}


looks like figma users. "i" icon instead of "?" here

I think we could add padding between the label and text below

Again these are limitations with ConfirmInfoRow. We need to see if its ok to generically change this for all usages.

...ges/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx

…it-simulation/permit-simulation.tsx Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>

…k/metamask-extension into permit_signature_simulation_info

...ges/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx

metamaskbot · 2024-06-12T10:20:58Z

Builds ready [966267e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (135 ± 172 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	130	86	17	8
		domContentLoaded	9	21	11	3	1
		load	42	1692	135	357	172
		domInteractive	9	21	11	3	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 5.11 KiB (0.08%)
common: 97 Bytes (0.00%)

metamaskbot · 2024-06-12T10:21:22Z

Builds ready [966267e]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (135 ± 172 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	69	130	86	17	8
		domContentLoaded	9	21	11	3	1
		load	42	1692	135	357	172
		domInteractive	9	21	11	3	1

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 5.11 KiB (0.08%)
common: 97 Bytes (0.00%)

metamaskbot · 2024-06-12T11:58:54Z

Builds ready [df189d4]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- offscreen: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (50 ± 4 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	65	95	81	8	4
		domContentLoaded	9	25	12	4	2
		load	40	71	50	7	4
		domInteractive	9	25	12	4	2

Bundle size diffs [🚨 Warning! Bundle size has increased!]

background: 0 Bytes (0.00%)
ui: 5.11 KiB (0.07%)
common: 97 Bytes (0.00%)

jpuri added 7 commits May 28, 2024 11:57

Changes in infor section of permit signature types

161814b

update

9ed12f0

update

df04719

update

fa6fc59

update

c3d5774

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

4e5c7fb

… permit_sign_info_section

Display simulation info for permit signatures

d1f85d9

jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) confirmation-redesign team-confirmations Push issues to confirmations team labels May 29, 2024

jpuri requested review from a team as code owners May 29, 2024 12:23

jpuri added 9 commits May 29, 2024 17:56

update

737d201

merge

18fb2c2

update

0be218d

update

d6164cf

Update

c224117

update

11dc68b

merge

a43bcf9

Update

a75ad4a

update

0d7bae3

Merge branch 'permit_sign_info_section' into permit_signature_simulat…

9d17164

…ion_info

jpuri added 4 commits May 31, 2024 16:32

update

e905920

Merge branch 'develop' of github.com:MetaMask/metamask-extension into…

22d2cb9

… permit_sign_info_section

update

1f6feb1

Merge branch 'permit_sign_info_section' into permit_signature_simulat…

80c2f99

…ion_info

digiwand reviewed Jun 7, 2024

View reviewed changes

jpuri and others added 6 commits June 7, 2024 17:38

Update ui/pages/confirmations/components/confirm/info/typed-sign/perm…

9320061

…it-simulation/permit-simulation.tsx Co-authored-by: Ariella Vu <20778143+digiwand@users.noreply.github.com>

Merge branch 'develop' into permit_signature_simulation_info

0ba6528

update

873059a

Merge branch 'permit_signature_simulation_info' of github.com:MetaMas…

82538d4

…k/metamask-extension into permit_signature_simulation_info

update

d11f9d5

update

2b64f36

jpuri mentioned this pull request Jun 10, 2024

fix: Simulations on signature pages should be displayed only if preference is enabled #25186

Merged

7 tasks

matthewwalsh0 reviewed Jun 11, 2024

View reviewed changes

...ges/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx Outdated Show resolved Hide resolved

...ges/confirmations/components/confirm/info/typed-sign/permit-simulation/permit-simulation.tsx Outdated Show resolved Hide resolved

Update

89083dd

jpuri requested review from SayaGT, bschorchit, digiwand and matthewwalsh0 June 11, 2024 10:54

jpuri added 3 commits June 11, 2024 17:12

Update

5207569

Update

1adb2ff

Update

966267e

matthewwalsh0 approved these changes Jun 12, 2024

View reviewed changes

pedronfigueiredo approved these changes Jun 12, 2024

View reviewed changes

Merge branch 'develop' into permit_signature_simulation_info

df189d4

jpuri merged commit 57b9c82 into develop Jun 12, 2024

jpuri deleted the permit_signature_simulation_info branch June 12, 2024 12:07

github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jun 12, 2024

github-actions bot locked and limited conversation to collaborators Jun 12, 2024

metamaskbot added the release-12.1.0 Issue or pull request that will be included in release 12.1.0 label Jun 12, 2024

Conversation

jpuri commented May 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented May 29, 2024

Uh oh!

codecov bot commented May 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

metamaskbot commented May 30, 2024

Uh oh!

metamaskbot commented May 31, 2024

Uh oh!

digiwand Jun 7, 2024

Choose a reason for hiding this comment

Uh oh!

jpuri Jun 7, 2024

Choose a reason for hiding this comment

Uh oh!

bschorchit Jun 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jpuri Jun 11, 2024

Choose a reason for hiding this comment

Uh oh!

digiwand Jun 7, 2024

Choose a reason for hiding this comment

Uh oh!

jpuri Jun 7, 2024

Choose a reason for hiding this comment

Uh oh!

digiwand Jun 7, 2024

Choose a reason for hiding this comment

Uh oh!

jpuri Jun 7, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

metamaskbot commented Jun 12, 2024

Uh oh!

metamaskbot commented Jun 12, 2024

Uh oh!

metamaskbot commented Jun 12, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

jpuri commented May 29, 2024 •

edited

Loading

codecov bot commented May 30, 2024 •

edited

Loading

bschorchit Jun 7, 2024 •

edited

Loading