Description

@danjm reported that the Privacy Policy wasn't disappearing after being interacted with. The problem is that the stored setting is overidden by initState being spread into the arguments.

Related issues

Fixes: N/A

Manual testing steps

1. Set PRIVACY_POLICY_DATE in ui/helpers/constants/privacy-policy.ts to today's date
2. Click to dismiss the privacy policy
3. See the privacy policy toast disappear

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.