Skip to content

cherry-pick test: fix flaky test `Import ERC1155 NFT should be... (#24709) into v11.16.1#24847

Merged
danjm merged 1 commit intoVersion-v11.16.1from
Version-v11.16.1-CPick-e2e-nft-fix
May 28, 2024
Merged

cherry-pick test: fix flaky test `Import ERC1155 NFT should be... (#24709) into v11.16.1#24847
danjm merged 1 commit intoVersion-v11.16.1from
Version-v11.16.1-CPick-e2e-nft-fix

Conversation

@dbrans
Copy link
Copy Markdown
Contributor

@dbrans dbrans commented May 28, 2024

cherry-pick test: fix flaky test `Import ERC1155 NFT should be able to import an … 3ddb0d4 (#24709) into v11.16.1

No merge conflicts

…ERC1155 NFT that user owns` (#24709)

## **Description**
This PR fixes the flaky tests related to ERC1155 token imports.
The problem is that whenever we import a token, we are making a call to
IPFS, which was currently not mocked. This caused that anytime that the
response took long, the test failed.

The fix is simply add a mock for the IPFS request.

However, this shows that we have a bug in the Import process, as we
should be able to import the token even if the IPFS call has not ended.
Now, it might take several minutes, and we can import the token once we
get the timeout response `504`.
I opened an issue
[here](#24710)


## **Related issues**

Fixes: #24604

## **Manual testing steps**

1. Run the test multiple times `yarn test:e2e:single
test/e2e/tests/tokens/nft/import-erc1155.spec.js --browser=firefox
--leave-running --retryUntilFailure --retries=10`
2. Check ci

## **Screenshots/Recordings**

![Screenshot from 2024-05-22
15-42-15](https://github.com/MetaMask/metamask-extension/assets/54408225/2dbd4f9f-8e22-47da-9aaa-4e5b002b47d8)



https://github.com/MetaMask/metamask-extension/assets/54408225/a397575b-52a9-47d7-8243-c0fec734e6d8



## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
@dbrans dbrans marked this pull request as ready for review May 28, 2024 22:23
@dbrans dbrans requested a review from a team as a code owner May 28, 2024 22:23
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 28, 2024
@dbrans dbrans changed the title cherry-pick test: fix flaky test `Import ERC1155 NFT should be able to import an … (#24709) cherry-pick test: fix flaky test `Import ERC1155 NFT should be... (#24709) into v11.16.1 May 28, 2024
@danjm danjm merged commit 3f270a0 into Version-v11.16.1 May 28, 2024
@danjm danjm deleted the Version-v11.16.1-CPick-e2e-nft-fix branch May 28, 2024 22:28
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
@metamaskbot metamaskbot added the release-11.16.1 Issue or pull request that will be included in release 11.16.1 label May 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

No release label on PR. Adding release label release-11.16.1 on PR, as PR was cherry-picked in branch 11.16.1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-11.16.1 Issue or pull request that will be included in release 11.16.1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants