Skip to content

chore: Disable immutableCheck by default#24832

Merged
FrederikBolding merged 1 commit intodevelopfrom
fb/disable-immutableCheck
May 28, 2024
Merged

chore: Disable immutableCheck by default#24832
FrederikBolding merged 1 commit intodevelopfrom
fb/disable-immutableCheck

Conversation

@FrederikBolding
Copy link
Copy Markdown
Member

Description

Disable immutableCheck by default since it is very taxing on performance with the current size of the MetaMask state.

@FrederikBolding FrederikBolding added the team-extension-platform Extension Platform team label May 28, 2024
@FrederikBolding FrederikBolding requested a review from a team as a code owner May 28, 2024 15:54
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label May 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [59e079e]
Page Load Metrics (416 ± 390 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6312292157
domContentLoaded9401373
load522487416812390
domInteractive9401373
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -108 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@FrederikBolding FrederikBolding merged commit 6a5dd69 into develop May 28, 2024
@FrederikBolding FrederikBolding deleted the fb/disable-immutableCheck branch May 28, 2024 21:22
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-extension-platform Extension Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants