Description

There is a current ci failure on the vault decryption chrome test where we are trying to disable all the setting options using the toggles. However, one of the toggles has a confirmation popup that is displayed whenever we try to disable it. The current code doesn't take into account the confirmation popup so the test fails at this point.

The fix is to disable this specific setting (Profile Sync) individually, like it's done with another setting which also has a specific confirm popup, and then perform the rest of toggle offs.

Related issues

Fixes:

Manual testing steps

1. You can remove the filter for running the vault decryption in this branch (or just check the job I ran below)

Screenshots/Recordings

This is the current failure point, where we are toggling off all the list of items but the Profile Sync has a confirmation pop-up, which makes the test fail at this point.

• Ci job now fixed: https://app.circleci.com/pipelines/github/MetaMask/metamask-extension/83243/workflows/45317b55-f2ae-4907-8bda-6a414967e357/jobs/2978094/steps

• Ci job successful:

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.