Skip to content

fix: push Privacy policy date to year 2099#24829

Merged
danjm merged 2 commits intodevelopfrom
jb-push-privacy-policy
May 28, 2024
Merged

fix: push Privacy policy date to year 2099#24829
danjm merged 2 commits intodevelopfrom
jb-push-privacy-policy

Conversation

@jonybur
Copy link
Copy Markdown
Contributor

@jonybur jonybur commented May 28, 2024 •
edited
Loading

Description

Sets the time for the new privacy policy for 2099, so that the feature is not released yet. This is until we figure out a correct date for the feature.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jonybur jonybur requested a review from a team as a code owner May 28, 2024 14:33
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 28, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@jonybur jonybur added the team-core-extension-ux Core Extension UX team label May 28, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 28, 2024

Builds ready [7d0f54f]
Page Load Metrics (1452 ± 602 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint682001244220
domContentLoaded95219126
load56290714521253602
domInteractive95219126
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@danjm danjm merged commit 2a2dfb4 into develop May 28, 2024
@danjm danjm deleted the jb-push-privacy-policy branch May 28, 2024 21:41
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@NidhiKJha NidhiKJha NidhiKJha approved these changes

+1 more reviewer

@darkwing darkwing darkwing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-core-extension-ux Core Extension UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@jonybur @metamaskbot @darkwing @NidhiKJha @gauthierpetetin @danjm