Skip to content

fix: personal sign to use a fixed alertKey#24817

Merged
vinistevam merged 3 commits intodevelopfrom
fix/personal-sign-alert-key
May 28, 2024
Merged

fix: personal sign to use a fixed alertKey#24817
vinistevam merged 3 commits intodevelopfrom
fix/personal-sign-alert-key

Conversation

@vinistevam
Copy link
Copy Markdown
Contributor

@vinistevam vinistevam commented May 28, 2024 •
edited
Loading

Description

This PR updates the alertKey prop in the AlertRow component within the PersonalSign component. The key change is replacing the translatable label passed with the correct key 'requestFrom'.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

AlertRows are not available to the user.
Test regression for signature and personal sign re-designed confirmations.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@vinistevam vinistevam added the team-confirmations Push issues to confirmations team label May 28, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 28, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@vinistevam vinistevam marked this pull request as ready for review May 28, 2024 13:51
@vinistevam vinistevam requested a review from a team as a code owner May 28, 2024 13:51
@codecov
Copy link
Copy Markdown

codecov bot commented May 28, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.74%. Comparing base (70b2258) to head (91cebab).

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop   #24817   +/-   ##
========================================
  Coverage    65.74%   65.74%           
========================================
  Files         1366     1366           
  Lines        54227    54227           
  Branches     14106    14106           
========================================
  Hits         35648    35648           
  Misses       18579    18579

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 28, 2024

Builds ready [945e27f]
Page Load Metrics (817 ± 543 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint69144106199
domContentLoaded10411574
load6529638171130543
domInteractive10411574
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -6 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 28, 2024

Builds ready [91cebab]
Page Load Metrics (819 ± 546 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint751931063115
domContentLoaded98017167
load6227868191137546
domInteractive98017167
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -6 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@vinistevam vinistevam merged commit 5b8b936 into develop May 28, 2024
@vinistevam vinistevam deleted the fix/personal-sign-alert-key branch May 28, 2024 17:40
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@matthewwalsh0 matthewwalsh0 matthewwalsh0 approved these changes

+1 more reviewer

@digiwand digiwand digiwand approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-confirmations Push issues to confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@vinistevam @metamaskbot @pedronfigueiredo @matthewwalsh0 @digiwand @gauthierpetetin