Skip to content

chore: Update Jest to v29.7.0#24804

Merged
legobeat merged 1 commit intodevelopfrom
update-jest-29.7
May 28, 2024
Merged

chore: Update Jest to v29.7.0#24804
legobeat merged 1 commit intodevelopfrom
update-jest-29.7

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented May 27, 2024 •
edited by github-actions bot
Loading

Description

Update jest to the latest in-range version (v29.7.0), and update related dependencies to the closest matching version.

This was required because the current Jest version doesn't have the advanceTimersByTimeAsync function, which I need to use in a test in another PR.

Open in GitHub Codespaces

Related issues

Needed for unit tests for #24503

Manual testing steps

N/A

Screenshots/Recordings

N/A

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@Gudahtt Gudahtt added the team-extension-platform Extension Platform team label May 27, 2024
@Gudahtt
chore: Update Jest to v29.7.0
abcb5df 
Update `jest` to the latest in-range version (`v29.7.0`), and update
related dependencies to the closest matching version.

This was required because the current Jest version doesn't have the
`advanceTimersByTimeAsync` function, which I need to use in a test in
another PR.
@Gudahtt Gudahtt force-pushed the update-jest-29.7 branch from e2b89f5 to abcb5df Compare May 27, 2024 21:18
@Gudahtt Gudahtt marked this pull request as ready for review May 27, 2024 22:13
@Gudahtt Gudahtt requested a review from a team as a code owner May 27, 2024 22:13
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 27, 2024

Builds ready [abcb5df]
Page Load Metrics (868 ± 523 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint65155972613
domContentLoaded84617136
load5325278681089523
domInteractive84617136
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@legobeat legobeat requested a review from a team May 27, 2024 23:00
@legobeat legobeat merged commit 8e75d16 into develop May 28, 2024
@legobeat legobeat deleted the update-jest-29.7 branch May 28, 2024 10:02
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DDDDDanica DDDDDanica DDDDDanica approved these changes

@salimtb salimtb salimtb approved these changes

+1 more reviewer

@legobeat legobeat legobeat approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-extension-platform Extension Platform team

Projects

PR review queue
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Gudahtt @metamaskbot @DDDDDanica @salimtb @legobeat @gauthierpetetin