Skip to content

docs: adding recover-phrase-stories#24781

Merged
georgewrmarshall merged 2 commits intodevelopfrom
docs/srp-stories
May 28, 2024
Merged

docs: adding recover-phrase-stories#24781
georgewrmarshall merged 2 commits intodevelopfrom
docs/srp-stories

Conversation

@georgewrmarshall
Copy link
Copy Markdown
Contributor

Description

This pull request adds three new stories for the recovery phrase components used in the onboarding process. The stories included are for the ConfirmRecoveryPhrase, RecoveryPhraseChips, and ReviewRecoveryPhrase components. These stories will help in visually testing and verifying the behavior of these components during the onboarding process.

Related issues

Fixes: N/A

Manual testing steps

  1. Open Storybook.
  2. Navigate to the ConfirmRecoveryPhrase story.
  3. Verify the component displays and behaves correctly.
  4. Navigate to the RecoveryPhraseChips story.
  5. Check that the component is rendered correctly and functions as expected.
  6. Navigate to the ReviewRecoveryPhrase story.
  7. Ensure the component is displayed accurately and operates as intended.

Screenshots/Recordings

Before

before720.mov

After

after720.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability.
  • I’ve included tests if applicable.
  • I’ve documented my code using JSDoc format if applicable.
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g., pulled and built the branch, run the app, tested the code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and/or screenshots.

@georgewrmarshall georgewrmarshall added area-documentation Issues relating to documentation, in the codebase and off. team-design-system All issues relating to design system in Extension labels May 25, 2024
@georgewrmarshall georgewrmarshall self-assigned this May 25, 2024
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@georgewrmarshall georgewrmarshall marked this pull request as ready for review May 25, 2024 20:32
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner May 25, 2024 20:32
@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [e497188]
Page Load Metrics (429 ± 418 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint57132842010
domContentLoaded8291363
load462634429871418
domInteractive8291363
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Copy Markdown
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Really nice stories

@georgewrmarshall georgewrmarshall merged commit 2b5991f into develop May 28, 2024
@georgewrmarshall georgewrmarshall deleted the docs/srp-stories branch May 28, 2024 17:24
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-documentation Issues relating to documentation, in the codebase and off. release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants