fix: adding missing overlay alternative color to helpers#24780
Merged
georgewrmarshall merged 2 commits intodevelopfrom May 28, 2024
Merged
fix: adding missing overlay alternative color to helpers#24780georgewrmarshall merged 2 commits intodevelopfrom
georgewrmarshall merged 2 commits intodevelopfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Comment on lines
-173
to
+171
| <Typography color={TextColor.textDefault}> | ||
| BorderColor.borderDefault | ||
| </Typography> | ||
| <Text color={TextColor.textDefault}>BorderColor.borderDefault</Text> |
Contributor
Author
There was a problem hiding this comment.
Replacing deprecated Typography component from docs
| <Typography color={TextColor.textDefault}> | ||
| BackgroundColor.backgroundDefault | ||
| </Typography> | ||
| <Text color={TextColor.textDefault}>BackgroundColor.backgroundDefault</Text> |
Contributor
Author
There was a problem hiding this comment.
Replacing deprecated Typography component from docs
Comment on lines
+398
to
+402
| <Box padding={3} backgroundColor={BackgroundColor.overlayAlternative}> | ||
| <Text color={TextColor.overlayInverse}> | ||
| BackgroundColor.overlayAlternative | ||
| </Text> | ||
| </Box> |
Contributor
Author
There was a problem hiding this comment.
Including overlay alternative color to Box stories
7 tasks
Collaborator
Builds ready [71211e0]
Page Load Metrics (503 ± 424 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
brianacnguyen
approved these changes
May 28, 2024
NidhiKJha
approved these changes
May 28, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This pull request adds a missing overlay alternative color to the design system enums. The inclusion of this color aims to enhance the consistency and completeness of the design system, providing additional options for overlay elements. This improvement helps ensure that all possible overlay scenarios are covered within the design system, making it more robust and flexible for various UI implementations.
Related issues
Fixes: N/A
Manual testing steps
yarn storybook.Boxbackground color story.Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist