fix: Set ENABLE_MV3=true for lavamoat:auto#24773
Conversation
…eration includes dependencies of the offscreen document
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
@metamaskbot update-policies |
|
Policies updated |
|
@metamaskbot update-policies |
|
Policies updated |
eeb7424 to
ed48a12
Compare
Builds ready [ed48a12]
Page Load Metrics (1226 ± 562 ms)
Bundle size diffs
|
|
The MV3 tests are failing on this branch, but they are passing on https://github.com/MetaMask/metamask-extension/tree/provider-retry-fix-plus-mv3-policy-fix, which is this branch + the commits from #24672 (both PRs are needed to get these tests passing). This should count as validation for this PR. |
davidmurdoch
left a comment
There was a problem hiding this comment.
Shipit! Branch is out of date with develo, so don't forget to check for potential issues before merging !
|
Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6. |
Description
The lavamoat policy file generation on develop is not accounting for the offscreen document when the polcies are being generated. This is causing MV3 tests to fail because
@trezor/connect-web, which is only imported in the offscreen, is not covered by the lavamoat policy, resulting in an error being thrown in the offscreen document.The fix is to set ENABLE_MV3=true for
lavamoat:webapp:autoandlavamoat:webapp:auto:ci, resulting in the offscreen document being included in the files used policy generation. Policy files then also need to be updated.Manual testing steps
Snaps MV3 tests should pass on https://github.com/MetaMask/metamask-extension/tree/provider-retry-fix-plus-mv3-policy-fix, which is a combination of this branch and the branch for #24672, both of which are needed to get snaps mv3 tests passing.
Pre-merge author checklist
Pre-merge reviewer checklist