feat: Add new content on the STX status page#24772
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
7b69813 to
d2aa0b6
Compare
Collaborator
Builds ready [d2aa0b6]
Page Load Metrics (169 ± 203 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
d2aa0b6 to
d07ef74
Compare
dbrans
previously approved these changes
May 28, 2024
| if (!isDapp || !isSmartTransactionPending) { | ||
| return null; | ||
| } | ||
| const t = useI18nContext(); |
Contributor
There was a problem hiding this comment.
Just a heads-up, it’s best to place hooks at the top of the render to avoid calling them conditionally like this.
Contributor
Author
There was a problem hiding this comment.
I've updated the code. Ideally we would have it as a part of our linting process, because right now this rule is not enforced there.
dbrans
approved these changes
May 28, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24772 +/- ##
===========================================
+ Coverage 65.77% 65.78% +0.01%
===========================================
Files 1366 1366
Lines 54238 54244 +6
Branches 14108 14109 +1
===========================================
+ Hits 35670 35680 +10
+ Misses 18568 18564 -4 ☔ View full report in Codecov by Sentry. |
klejeune
approved these changes
May 28, 2024
Collaborator
Builds ready [ad7d112]
Page Load Metrics (679 ± 509 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Adds and update tests, update a message
ad7d112 to
ca36630
Compare
Collaborator
Builds ready [ca36630]
Page Load Metrics (544 ± 455 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Collaborator
|
Missing release label release-11.16.1 on PR. Adding release label release-11.16.1 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.1. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the STX status page you will now see this text for a pending dapp transaction:
You may close this window anytime.Related issues
Fixes:
Manual testing steps
You may close this window anytime.Close extensionbutton when the transaction is not pending anymoreScreenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist