feat: Implement the "Manage in settings" variation for the STX Opt In modal by dan437 · Pull Request #24771 · MetaMask/metamask-extension

dan437 · 2024-05-24T13:30:30Z

Description

Slight variation for the STX Opt In modal: Add a link to "Manage in settings"

Related issues

Fixes:

Manual testing steps

Install the extension from scratch
After the initial setup you will see the STX Opt In modal
It will show the "Manage in settings" link. After clicking on it we opt out a user from Smart Transactions, but they will be redirected to Advanced Settings, where they can turn it on if they want or just close the Settings

Screenshots/Recordings

STX Opt In modal:

Advanced Settings with STX:

Pre-merge author checklist

I’ve followed MetaMask Coding Standards.
I've completed the PR template to the best of my ability
I’ve included tests if applicable
I’ve documented my code using JSDoc format if applicable
I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2024-05-24T13:30:43Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

dbrans

Fantastic Dan!

metamaskbot · 2024-05-24T15:10:38Z

Builds ready [1113c78]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1403 ± 581 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	64	183	107	32	16
		domContentLoaded	10	30	14	5	2
		load	51	2701	1403	1211	581
		domInteractive	10	30	14	5	2

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 298 Bytes (0.00%)
common: -21 Bytes (-0.00%)

codecov · 2024-05-27T14:05:11Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.72%. Comparing base (3af209b) to head (8448fe2).
Report is 1 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #24771      +/-   ##
===========================================
+ Coverage    65.69%   65.72%   +0.03%     
===========================================
  Files         1360     1360              
  Lines        54081    54083       +2     
  Branches     14051    14051              
===========================================
+ Hits         35525    35542      +17     
+ Misses       18556    18541      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2024-05-27T14:34:07Z

Builds ready [8448fe2]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (751 ± 498 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	66	179	103	28	13
		domContentLoaded	9	38	14	8	4
		load	54	2574	751	1038	498
		domInteractive	9	38	14	8	4

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 298 Bytes (0.00%)
common: -21 Bytes (-0.00%)

Update a .snap file Update E2E tests

dbrans · 2024-05-28T12:40:47Z

ui/components/app/smart-transactions/smart-transactions-opt-in-modal.tsx

      className="mm-smart-transactions-opt-in-modal__no-thanks-link"
    >
-      {t('dontEnableEnhancedProtection')}
+      {t('manageInSettings')}


Dan, I was thinking about the "managing in settings" button and had a small suggestion. The button text seems to imply that the user is deferring the opt-in decision rather than explicitly declining it. Since the default for an "opt-in" is false, calling setSmartTransactionsOptInStatus(false) might not be necessary when they click that button.

However, if we need to track whether the user has seen the opt-in modal (set smartTransactionsOptInStatus to something other than undefined), maybe we could rename the handler to "handleMarkOptInModalSeen" instead of "handleNoThanks"? And we could add a comment like: "We setSmartTransactionsOptInStatus(false) to track that user has seen the opt-in modal."

What do you think?

As we have discussed, I've renamed the NoThanks component to ManageInSettings + its on-click handler as well. I've also added an explanation comment about that we need to call setSmartTransactionsOptInStatus(false), so a user wouldn't see the opt-in modal again.

metamaskbot · 2024-05-28T13:03:34Z

Builds ready [05bcec5]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (834 ± 499 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	60	177	99	28	13
		domContentLoaded	8	46	12	8	4
		load	49	2400	834	1040	499
		domInteractive	8	46	12	8	4

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 298 Bytes (0.00%)
common: -21 Bytes (-0.00%)

dbrans

Amazing work, Dan!

metamaskbot · 2024-05-28T15:15:15Z

Builds ready [c419b85]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9
- content-script: 0
- ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (846 ± 504 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	70	180	102	25	12
		domContentLoaded	9	17	11	2	1
		load	58	2462	846	1050	504
		domInteractive	9	17	11	2	1

Bundle size diffs [🚀 Bundle size reduced!]

background: 0 Bytes (0.00%)
ui: 314 Bytes (0.00%)
common: -21 Bytes (-0.00%)

metamaskbot · 2024-05-29T00:09:43Z

Missing release label release-11.16.1 on PR. Adding release label release-11.16.1 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.1.

dan437 requested a review from a team as a code owner May 24, 2024 13:30

dbrans previously approved these changes May 24, 2024

View reviewed changes

dbrans added the team-transactions Transactions team label May 24, 2024

dbrans changed the title ~~Implement the "Manage in settings" variation for the STX Opt In modal~~ feat: Implement the "Manage in settings" variation for the STX Opt In modal May 24, 2024

dan437 dismissed dbrans’s stale review via 4898434 May 27, 2024 13:05

dan437 force-pushed the opt-in-variation branch from 1113c78 to 4898434 Compare May 27, 2024 13:05

dan437 added 3 commits May 28, 2024 14:19

Implement the "Manage in settings" variation for the STX Opt In modal

bbf30c4

Update a .snap file Update E2E tests

Add tests for the "SmartTransactionsOptInModal" component

2855e5f

Fix linting

05bcec5

dan437 force-pushed the opt-in-variation branch from 8448fe2 to 05bcec5 Compare May 28, 2024 12:19

dbrans previously approved these changes May 28, 2024

View reviewed changes

Renaming

c419b85

dan437 dismissed dbrans’s stale review via c419b85 May 28, 2024 13:06

dbrans approved these changes May 28, 2024

View reviewed changes

klejeune approved these changes May 28, 2024

View reviewed changes

dan437 merged commit 82fe51c into develop May 28, 2024

dan437 deleted the opt-in-variation branch May 28, 2024 16:18

github-actions bot locked and limited conversation to collaborators May 28, 2024

metamaskbot added release-11.18.0 release-11.16.1 Issue or pull request that will be included in release 11.16.1 and removed release-11.18.0 labels May 28, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Implement the "Manage in settings" variation for the STX Opt In modal#24771

feat: Implement the "Manage in settings" variation for the STX Opt In modal#24771
dan437 merged 4 commits intodevelopfrom
opt-in-variation

dan437 commented May 24, 2024 •

edited by github-actions bot

Loading

Uh oh!

github-actions bot commented May 24, 2024

Uh oh!

dbrans left a comment

Uh oh!

metamaskbot commented May 24, 2024

Uh oh!

codecov bot commented May 27, 2024

Uh oh!

metamaskbot commented May 27, 2024

Uh oh!

dbrans May 28, 2024

Uh oh!

dan437 May 28, 2024

Uh oh!

metamaskbot commented May 28, 2024

Uh oh!

dbrans left a comment

Uh oh!

metamaskbot commented May 28, 2024

Uh oh!

metamaskbot commented May 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

dan437 commented May 24, 2024 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Related issues

Manual testing steps

Screenshots/Recordings

Pre-merge author checklist

Pre-merge reviewer checklist

Uh oh!

github-actions bot commented May 24, 2024

Uh oh!

dbrans left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented May 24, 2024

Uh oh!

codecov bot commented May 27, 2024

Codecov Report

Uh oh!

metamaskbot commented May 27, 2024

Uh oh!

dbrans May 28, 2024

Choose a reason for hiding this comment

Uh oh!

dan437 May 28, 2024

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented May 28, 2024

Uh oh!

dbrans left a comment

Choose a reason for hiding this comment

Uh oh!

metamaskbot commented May 28, 2024

Uh oh!

metamaskbot commented May 29, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dan437 commented May 24, 2024 •

edited by github-actions bot

Loading