Skip to content

chore: upgrade design tokens and updating design token css path#24760

Merged
georgewrmarshall merged 1 commit intodevelopfrom
upgrade/design-tokens-v3
May 28, 2024
Merged

chore: upgrade design tokens and updating design token css path#24760
georgewrmarshall merged 1 commit intodevelopfrom
upgrade/design-tokens-v3

Conversation

@georgewrmarshall
Copy link
Copy Markdown
Contributor

@georgewrmarshall georgewrmarshall commented May 23, 2024

Description

This PR updates the design tokens to version 3 and modifies the stylesheet path to point to the dist folder accordingly.

Related issues

Fixes: #24754

Manual testing steps

  1. Open the MetaMask extension.
  2. Navigate through different UI elements to ensure the new design tokens are applied correctly.
  3. Verify that the stylesheets are being loaded from the dist folder without any issues.

Screenshots/Recordings

Before

before720.mov

Storybook unminified stylesheet

Screenshot 2024-05-23 at 4 45 07 PM

After

after720.mov

Storybook still works with minified stylesheet

Screenshot 2024-05-23 at 4 47 18 PM

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability.
  • I’ve included tests if applicable.
  • I’ve documented my code using JSDoc format if applicable.
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g., pulled and built branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@georgewrmarshall georgewrmarshall added the team-design-system All issues relating to design system in Extension label May 23, 2024
@georgewrmarshall georgewrmarshall self-assigned this May 23, 2024
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Copy Markdown
Collaborator

Builds ready [5b9bdbd]
Page Load Metrics (1009 ± 557 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6614293199
domContentLoaded10281442
load54282610091159557
domInteractive10281442
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@georgewrmarshall georgewrmarshall marked this pull request as ready for review May 23, 2024 23:48
@georgewrmarshall georgewrmarshall requested a review from a team as a code owner May 23, 2024 23:48
@georgewrmarshall georgewrmarshall requested review from NidhiKJha, brianacnguyen and darkwing and removed request for garrettbear May 27, 2024 15:56
@georgewrmarshall georgewrmarshall merged commit 4d67d4a into develop May 28, 2024
@georgewrmarshall georgewrmarshall deleted the upgrade/design-tokens-v3 branch May 28, 2024 17:22
@github-actions github-actions bot locked and limited conversation to collaborators May 28, 2024
@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-design-system All issues relating to design system in Extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade design tokens to version 3.0

5 participants