Description

This PR attempts to fix the flaky test Migrate Opensea to Blockaid Banner @no-mmi Shows up on Token Approval transaction confirmations

This test fails whenever we click Create Token for deploying an ERC20 token, as the popup is not triggered and we remain in the test dapp.

I haven't been able to reproduce this failure locally. However, after looking into the code and the context of flakiness, I can confirm that:

• I've seen that we are doing several unnecessary steps for the test setup, like connecting to the test dapp, or deploying an ERC20 contract. This can be achieved by fixtures, so I've added the fixtures and got rid of a good chunk of the code. The good part is that the test failure precisely happens on the test setup, which is now removed
• It might be that there is a race condition between the Connect to the test Dapp and the Create Token steps, where the dapp has not yet the connected address for triggering the Create Token but the button is already enabled, resulting in the error in the test dapp unknown account and popup not being opened (see video below). However, those 2 steps are now removed from the test, meaning any potential race condition at this point won't happen anymore
• I've added the logInWithBalanceValidation instead of the unlockWallet to make sure the balance is loaded before triggering the interaction

For the above points, I have strong reasons for wanting to implement the changes on this PR, despite not being 100% sure of the above being the root cause.

Related issues

Fixes: another item of this list #24603

Manual testing steps

1. Run this test locally several times `yarn test:e2e:single test/e2e/tests/ppom/migrate-opensea-to-blockaid-banner.spec.js --browser=firefox --leave-running --retryUntilFailure --retries=10
2. Check ci jobs

Screenshots/Recordings

This is not the test environment, however here I demonstrate how would look like if the create token is triggered before the dapp has the connected account resolved

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've completed the PR template to the best of my ability
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.