Skip to content

style: Improve style notification items#24731

Merged
matteoscurati merged 29 commits intodevelopfrom
style/improve-style-notification-items
May 27, 2024
Merged

style: Improve style notification items#24731
matteoscurati merged 29 commits intodevelopfrom
style/improve-style-notification-items

Conversation

@matteoscurati
Copy link
Copy Markdown
Contributor

@matteoscurati matteoscurati commented May 23, 2024 •
edited by github-actions bot
Loading

Description

This PR introduces some style improvements and fixes for typos related to notifications.

Open in GitHub Codespaces

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Figma: https://www.figma.com/design/c7GgNw2kScGrVyRGAPhwEd/Notifications?node-id=6271%3A37657&t=VBIEJhBc9M0linw8-1

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 23, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Base automatically changed from feat/new-metamask-notifications to develop May 23, 2024 12:11
@matteoscurati matteoscurati dismissed Prithpal-Sooriya’s stale review May 23, 2024 12:11

The base branch was changed.

@matteoscurati matteoscurati changed the base branch from develop to feat/new-metamask-notifications May 23, 2024 15:19
@matteoscurati matteoscurati changed the title Improve style notification items Style: Improve style notification items May 23, 2024
@matteoscurati
style: 💄 update notification item background color
ef27e46
@matteoscurati
style: 💄 update sent/from label
4fd8c5f
@matteoscurati
refactor: ♻️ the whole Network fee details area should not be clickab…
25d7e5d 
…le but the Details dropdown
@matteoscurati
refactor: ♻️ the Dollar Sign ($) should be in front of the figure not…
a730630 
… behind it
@matteoscurati
feat: 💄 add a border to the Assets and Network icons
cedebc8
@matteoscurati
style: ✏️ network should not have a double colon
c8fb797
@matteoscurati
fix: 🐛 update the title in the sent/received NFT page
7769e81
@matteoscurati
refactor: ♻️ check if nft/collection images are suitable
11811a9
@matteoscurati
test: ✅ fix a test
19a219c
@matteoscurati
refactor: ♻️ show what asset the user staked
4b8ab7e
@matteoscurati
refactor: 🏷️ update label
d21f2ff
@matteoscurati
refactor: ✏️ fix texts for staking/unstaking notifications
730f138
@matteoscurati
feat: 🔥 use the right onchain notifications
02bba30
@matteoscurati matteoscurati force-pushed the style/improve-style-notification-items branch from dd70d6e to 02bba30 Compare May 23, 2024 16:06
@matteoscurati matteoscurati changed the title Style: Improve style notification items style: Improve style notification items May 23, 2024
@matteoscurati matteoscurati changed the base branch from feat/new-metamask-notifications to develop May 23, 2024 16:12
@matteoscurati matteoscurati marked this pull request as ready for review May 23, 2024 16:21
@matteoscurati matteoscurati requested a review from a team as a code owner May 23, 2024 16:21
@matteoscurati matteoscurati requested a review from danjm May 23, 2024 16:21
@matteoscurati matteoscurati added the team-notifications-deprecated DEPRECATED: please use "team-assets" instead label May 23, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 23, 2024

Builds ready [4bd4ea3]
Page Load Metrics (1452 ± 551 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint711391012211
domContentLoaded9431684
load58297414521147551
domInteractive9431684
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 1.94 KiB (0.03%)
  • common: 88 Bytes (0.00%)

danjm
danjm previously approved these changes May 24, 2024
View reviewed changes
@matteoscurati matteoscurati dismissed stale reviews from Prithpal-Sooriya and danjm via 47ab5fe May 24, 2024 08:03
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 24, 2024

Builds ready [880e0df]
Page Load Metrics (993 ± 543 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint692221134220
domContentLoaded107019147
load5625729931131543
domInteractive107019147
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.21 KiB (0.03%)
  • common: 88 Bytes (0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 24, 2024

Builds ready [a7c6794]
Page Load Metrics (805 ± 539 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint641811073316
domContentLoaded95521136
load5130288051124539
domInteractive95521136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.21 KiB (0.03%)
  • common: 88 Bytes (0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 25, 2024

Builds ready [dbf4019]
Page Load Metrics (516 ± 431 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint6711684147
domContentLoaded95117115
load542503516898431
domInteractive95117115
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.21 KiB (0.03%)
  • common: 88 Bytes (0.00%)

@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 27, 2024

Builds ready [5cbe5da]
Page Load Metrics (751 ± 506 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint61163892613
domContentLoaded9181221
load5025007511053506
domInteractive9181221
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 2.21 KiB (0.03%)
  • common: 88 Bytes (0.00%)

@matteoscurati matteoscurati merged commit c704f9f into develop May 27, 2024
@matteoscurati matteoscurati deleted the style/improve-style-notification-items branch May 27, 2024 13:52
@github-actions github-actions bot locked and limited conversation to collaborators May 27, 2024
@gauthierpetetin gauthierpetetin added the release-12.0.0 Issue or pull request that will be included in release 12.0.0 label Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Prithpal-Sooriya Prithpal-Sooriya Prithpal-Sooriya approved these changes

+1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-12.0.0 Issue or pull request that will be included in release 12.0.0 team-notifications-deprecated DEPRECATED: please use "team-assets" instead

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@matteoscurati @metamaskbot @danjm @Prithpal-Sooriya @gauthierpetetin