Double check this getPlatform code.
This calls window.navigator, and the window does not exist on service workers.
We might want to replace this with global.navigator or self.navigator

@danjm is this function getPlatform used in other controllers? We are not seeing any regressions or errors using this? If it works, then feel free to keep using it @matteoscurati .

@Prithpal-Sooriya everything seems to be working correctly. I tried generating the links by also printing the different steps and everything seems to work

Because of this: https://github.com/MetaMask/metamask-extension/blob/develop/app/scripts/init-globals.js#L17

window, in our app/ code under mv3, refers to the ServiceWorkerGlobalScope and not an actual window. The ServiceWorkerGlobalScope has some, but not all, of the apis an actual window has. navigator is one of the APIs it does have, so this should be fine

I don't think ?? defaultNetwork?.rpcUrl should be here, as rpcUrl should never be a block explorer url

@danjm you’re right. This is the type:

export type NetworkConfiguration = {
    rpcUrl: string;
    chainId: Hex;
    ticker: string;
    nickname?: string;
    rpcPrefs?: {
        blockExplorerUrl: string;
    };
};

I removed defaultNetwork?.rpcUrl