chore: use Firefox ServiceBuilder and add geckodriver path for e2e in Linux + Firefox snap#24703
Merged
chore: use Firefox ServiceBuilder and add geckodriver path for e2e in Linux + Firefox snap#24703
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #24703 +/- ##
========================================
Coverage 67.40% 67.40%
========================================
Files 1289 1289
Lines 50248 50248
Branches 13011 13011
========================================
Hits 33865 33865
Misses 16383 16383 ☔ View full report in Codecov by Sentry. |
Collaborator
Builds ready [7e02c0c]
Page Load Metrics (1226 ± 564 ms)
Bundle size diffs
|
DDDDDanica
approved these changes
May 22, 2024
Collaborator
|
Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In this PR we enable an envar which fixes the e2e for running against Firefox, when the browser is installed as a snap (Linux).
For doing so, we need to leverage the Firefox ServiceBuilder class.
Using the service class by default is something that we already do in Chrome.
For Firefox, we only did this in the case a custom port was passed. Now it's done always, and in the case we pass a port, we configure it as we did.
Related issues
Fixes:
Manual testing steps
FIREFOX_SNAP=true yarn test:e2e:single test/e2e/tests/tokens/nft/import-erc1155.spec.js --browser=firefoxScreenshots/Recordings
Before
After
ff-snap-path-child.mp4
Pre-merge author checklist
Pre-merge reviewer checklist