Skip to content

chore: bump transaction-controller to 29.0.2#24701

Merged
dbrans merged 2 commits intodevelopfrom
dbrans/bump-txctlr
May 22, 2024
Merged

chore: bump transaction-controller to 29.0.2#24701
dbrans merged 2 commits intodevelopfrom
dbrans/bump-txctlr

Conversation

@dbrans
Copy link
Copy Markdown
Contributor

@dbrans dbrans commented May 22, 2024 •
edited
Loading

Description

Bump transaction controller to get a couple fixes in.

Open in GitHub Codespaces

Related issues

Fixes: #24586
Fixes: #24183
Related: #24359 @keithchew to verify

Manual testing steps

  1. Go to this page...

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented May 22, 2024

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dbrans dbrans added the team-transactions Transactions team label May 22, 2024
@dbrans dbrans changed the title bump transaction-controller to 29.0.2 chore: bump transaction-controller to 29.0.2 May 22, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 22, 2024

Builds ready [9f67ae6]
Page Load Metrics (895 ± 542 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint681821043416
domContentLoaded106817136
load5627278951130542
domInteractive106817136
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 1.08 KiB (0.02%)

@dbrans dbrans marked this pull request as ready for review May 22, 2024 01:43
@dbrans dbrans requested a review from a team as a code owner May 22, 2024 01:43
@dbrans dbrans mentioned this pull request May 22, 2024
Closed
@sleepytanya sleepytanya mentioned this pull request May 22, 2024
Closed
@dbrans dbrans merged commit 637c0f3 into develop May 22, 2024
@dbrans dbrans deleted the dbrans/bump-txctlr branch May 22, 2024 20:12
@github-actions github-actions bot locked and limited conversation to collaborators May 22, 2024
@metamaskbot metamaskbot added release-11.18.0 release-11.16.0 Issue or pull request that will be included in release 11.16.0 and removed release-11.18.0 labels May 22, 2024
@metamaskbot
Copy link
Copy Markdown
Collaborator

metamaskbot commented May 23, 2024

Missing release label release-11.16.0 on PR. Adding release label release-11.16.0 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cryptotavares cryptotavares cryptotavares approved these changes

+1 more reviewer

@danjm danjm danjm approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-transactions Transactions team

Projects

None yet

Milestone

No milestone

4 participants

@dbrans @metamaskbot @danjm @cryptotavares