Conversation
…esController?.enableMV3TimestampSave is false
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Collaborator
Builds ready [7803a91]
Page Load Metrics (969 ± 535 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Contributor
|
Thanks for the fix ! LGTM |
DDDDDanica
approved these changes
May 22, 2024
vthomas13
approved these changes
May 22, 2024
Collaborator
|
Missing release label release-11.16.6 on PR. Adding release label release-11.16.6 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.6. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This if block was added to allow us to easily toggle off the timestamp saving at an interval. (#24326)
enableMV3TimestampSavedefaults to true in the preferences controller, but on first install of the extension, before the preferences controller has been initialized, it will beundefined.We should ensure that this timestamp saving behaviour is able to occur on first install of the extension by only preventing it if
enableMV3TimestampSaveis explicitlyfalse.Manual testing steps
Repro broken:
ifblock that this PR modifiesTest fix:
ifblock that this PR modifiesPre-merge author checklist
Pre-merge reviewer checklist